Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E7FEE431FD0 for ; Wed, 11 Jan 2012 00:45:40 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vmKAkfHUazJR for ; Wed, 11 Jan 2012 00:45:40 -0800 (PST) Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 5A07C431FB6 for ; Wed, 11 Jan 2012 00:45:40 -0800 (PST) Received: by qcpx40 with SMTP id x40so21974qcp.26 for ; Wed, 11 Jan 2012 00:45:39 -0800 (PST) Received: by 10.224.52.75 with SMTP id h11mr29383168qag.46.1326271539668; Wed, 11 Jan 2012 00:45:39 -0800 (PST) Received: from localhost (nikula.org. [92.243.24.172]) by mx.google.com with ESMTPS id hv20sm2273214qab.22.2012.01.11.00.45.37 (version=SSLv3 cipher=OTHER); Wed, 11 Jan 2012 00:45:38 -0800 (PST) From: Jani Nikula To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH v3 2/4] emacs: add support for replying just to the sender In-Reply-To: References: <069a0cddd4e848314fb64da861b3bf5b4f053f14.1326224339.git.jani@nikula.org> User-Agent: Notmuch/0.10.2+187~g43d4f26 (http://notmuchmail.org) Emacs/23.1.1 (i686-pc-linux-gnu) Date: Wed, 11 Jan 2012 08:45:35 +0000 Message-ID: <87wr8yvd8w.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 08:45:41 -0000 On Wed, 11 Jan 2012 08:20:56 +0000, David Edmondson wrote: > On Tue, 10 Jan 2012 21:54:02 +0200, Jani Nikula wrote: > > Provide reply to sender counterparts to the search and show reply > > functions. Add key binding 'R' to reply to sender, while keeping 'r' as > > reply to all, both in search and show views. > > All looks fine. My only comments are nits. > > > -(defun notmuch-mua-reply (query-string &optional sender) > > +(defun notmuch-mua-reply (query-string &optional sender reply-all) > > (let (headers > > body > > (args '("reply"))) > > (if notmuch-show-process-crypto > > (setq args (append args '("--decrypt")))) > > + (if reply-all > > + (setq args (append args '("--reply-to=all"))) > > + (setq args (append args '("--reply-to=sender")))) > > (setq args (append args (list query-string))) > > I don't like how this ends up. How about something like: > > (defun notmuch-mua-reply (query-string &optional sender) > (let (headers > body > (args (nconc (list "reply" > (concat "--reply-to=" > (if reply-all "all" "sender"))) > (when notmuch-show-process-crypto > (list "--decrypt")) > (list query-string)))) > > But even that is not very nice. I think the original looks better, and is easier to grasp, even if it's perhaps not as lispy. Besides, the last time you thought this was fine (id:"cunehv91e05.fsf@hotblack-desiato.hh.sledj.net"), and the patch hasn't changed since. ;) BR, Jani.