Date: Sun, 19 Feb 2012 12:25:41 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by
 default
Message-ID: <20120219172541.GQ5991@mit.edu>
References: <1329632533-16152-1-git-send-email-amdragon@mit.edu>
	<m2k43jw43j.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m2k43jw43j.fsf@guru.guru-group.fi>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

Quoth Tomi Ollila on Feb 19 at 11:43 am:
> On Sun, 19 Feb 2012 01:22:10 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > Based on the thread at id:"20120213152858.GO27039@mit.edu" it seems
> > like people want show refresh to retain message state by default (I
> > certainly do), rather than reset it by default.  As a nice bonus, this
> > fixes a broken test.
> 
> Hmm
> 
> Every '=' keypress in a thread removes 'unread' tag from next unread 
> message :o

Oh dear.  It's slightly subtler than that, though.  Refreshing will
remove the unread tag from the first message matching the query.  (I
suspect you had tag:unread in your query?)  This is particularly
confusing for state-retaining refresh because that message might not
even be open.

> That is probably desirable feature when refreshing view without
> retaining state. Also, probably notmuch-show-refresh-view should
> be fixed not to mark next message unread when retaining state ?

I would argue that refresh should never have side-effects, so neither
case should mark anything read.  I'll send a v2.