Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 44DB6431FB6
	for <notmuch@notmuchmail.org>; Tue,  7 Feb 2012 02:30:19 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0.01
X-Spam-Level: 
X-Spam-Status: No, score=0.01 tagged_above=-999 required=5
	tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id oA+Z4U1gZX8w for <notmuch@notmuchmail.org>;
	Tue,  7 Feb 2012 02:30:18 -0800 (PST)
Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
	by olra.theworths.org (Postfix) with ESMTP id 7DA50431FAE
	for <notmuch@notmuchmail.org>; Tue,  7 Feb 2012 02:30:18 -0800 (PST)
Received: by guru.guru-group.fi (Postfix, from userid 501)
	id 5487268055; Tue,  7 Feb 2012 12:30:17 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Ethan Glasser-Camp <glasse@cs.rpi.edu>, notmuch@notmuchmail.org
Subject: Re: [PATCH] Free the results of scandir()
In-Reply-To: <1328609103-7870-1-git-send-email-glasse@cs.rpi.edu>
References: <1328609103-7870-1-git-send-email-glasse@cs.rpi.edu>
User-Agent: Notmuch/0.11.1+164~g6619341 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Tue, 07 Feb 2012 12:30:12 +0200
Message-ID: <m239an6imj.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: Ethan Glasser-Camp <ethan@betacantrips.com>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Feb 2012 10:30:19 -0000

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue,  7 Feb 2012 05:05:03 -0500, Ethan Glasser-Camp <glasse@cs.rpi.edu> =
wrote:
> From: Ethan Glasser-Camp <ethan@betacantrips.com>
>=20
> scandir() returns "strings allocated via malloc(3)" which are then
> "collected in array namelist which is allocated via
> malloc(3)". Currently we just free the array namelist. Instead, free
> all the entries of namelist, and then free namelist.
>=20
> entry only points to elements of namelist, so we don't free it
> separately.
> ---

+1

Tomi

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFPMP05oEBNrhe2D3URAtIiAJsH3W1dFLa7XkPHOJa0VSBgASz4GQCgmHAo
SV1oWmyyaPivI+D9cS2+Sik=
=K9a/
-----END PGP SIGNATURE-----
--=-=-=--