From: Tomi Ollila <tomi.ollila@iki.fi>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/2] Improve message threading
In-Reply-To: <1401113157-32454-1-git-send-email-sojkam1@fel.cvut.cz>
References: <1401113157-32454-1-git-send-email-sojkam1@fel.cvut.cz>
User-Agent: Notmuch/0.18.1+25~gdaf4b6f (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Sun, 10 Aug 2014 22:49:45 +0300
Message-ID: <m2fvh4azvq.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Mon, May 26 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:

> Hi all,
>
> I noticed that in certain situations notmuch does not reconstruct
> thread structure correctly. The fix was quite trivial - see the
> patches.
>
> The patch fixes my problem, however, as I learnt from the thread
> around id:87oazwjq1e.fsf@yoom.home.cworth.org, there are more problems
> in this code. I think that my problem is orthogonal to what was
> discussed there.
>
> The patch does not break any existing text (except two in
> T460-emacs-tree.sh, which fail even with 0.18 on my system).
>
> Cheers,
> -Michal

This series looks good to me, and patch 2/2 fixes the borken test
introduced in patch 1/2 -- i.e. the fix is clear, test is somewhat
tedious to be parsed by a human ;D

Tomi


>
> Michal Sojka (2):
>   Add test for incorrect threading of messages
>   Make parsing of References and In-Reply-To header less error prone
>
>  lib/database.cc             | 15 ++++++---------
>  test/T510-thread-replies.sh | 27 +++++++++++++++++++++++++++
>  2 files changed, 33 insertions(+), 9 deletions(-)
>
> -- 
> 2.0.0.rc2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch