From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: Add customization group for replying
In-Reply-To: <m2wr07fs0y.fsf@guru.guru-group.fi>
References: <1346919815-20397-1-git-send-email-sojkam1@fel.cvut.cz>
	<m2wr07fs0y.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.14+23~g9d68aca (http://notmuchmail.org) Emacs/24.1.1
	(x86_64-pc-linux-gnu)
Date: Thu, 06 Sep 2012 14:39:14 +0200
Message-ID: <87y5kntjf1.fsf@steelpick.2x.cz>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Thu, Sep 06 2012, Tomi Ollila wrote:
> On Thu, Sep 06 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
>
>> When one wants to customize the format of reply message, there is nothing
>> to tell the user how to do it.  Without knowing that construction of
>> reply buffer is actually implemented in the message package, it seems
>> that replying cannot be customized.
>>
>> Because I was getting annoyed by the empty line the between the citation
>> line and the quoted message, I figured out that changing this is fairly
>> easy when one knows what to customize.
>>
>> This patch adds notmuch-reply customization group that contains
>> references to the relevant customization options. The new group is easy
>> to find as it is shown as a result of running "M-x customize-group RET
>> notmuch RET".
>> ---
>
> So far good, but...
>
> You forgot to handle the current group setting for 
> notmuch-message-replied-tags -- currently notmuch-message.el has this:
>
> (defcustom notmuch-message-replied-tags '("replied")
>   "Tags to be automatically added to or removed from a message when it is
>   replied to.
> Any tag in the list will be added to a replied message or,
> if it is prefaced with a \"-\", removed.
>
> For example, if you wanted to add a \"replied\" tag and remove
> the \"inbox\" and \"todo\", you would set
>     (\"replied\" \"-inbox\" \"-todo\"\)"
>   :type 'list
>   :group 'notmuch-send)
>
> If the above was changed to 'normuch-send, (require 'notmuch-lib)
> was added to the beginning of notmuch-message.el and the defgroup
> below was written as
>
> (defgroup notmuch-reply
>   '((message-insertion custom-group)))
>    "Replying to messages.
>     ...
>
> would that work as expected ?

Hi Tomi,

I don't really get what are you trying to say. Do you mean that
notmuch-message-replied-tags is referenced from notmuch-lib.el without
(require 'notmuch-message)? I'm not sure whether it is required, but it
works here without problems.

Running M-x customize-variable RET notmuch-message-replied-tags RET
shows the following. Note that both groups are mentioned at the bottom.
No warning or errors are produced.

-Michal

--8<---------------cut here---------------start------------->8---
To apply changes, use the Save or Set buttons.
For details, see Saving Customizations in the Emacs manual.

                                          Search 

 Operate on all settings in this buffer:
  Set for current session   Save for future sessions 
  Undo edits   Reset to saved   Erase customizations     Exit 

Hide notmuch-message-replied-tags: '("replied")
    State : STANDARD. (mismatch)
   Tags to be automatically added to or removed from a message when it is replied to. Hide   
   Any tag in the list will be added to a replied message or,
   if it is prefaced with a "-", removed.
   
   For example, if you wanted to add a "replied" tag and remove
   the "inbox" and "todo", you would set
       ("replied" "-inbox" "-todo")
Groups: Notmuch Send Notmuch Reply
--8<---------------cut here---------------end--------------->8---