DomainKey-Signature: a=rsa-sha1; c=nofws; d=microcomaustralia.com.au;
 s=google;	h=mime-version:x-originating-ip:in-reply-to:references:date
	:message-id:subject:from:to:cc:content-type;
	b=bnwzHsdSUwplVXB5Xy/Sjo0xx7fK9olrQDLnGSg3uPXjZQ4EdLV1Q/nqNU4WRAFx0U
	3UZtOykLORTH7eI0HRP3UKQoujkkfXREdJjuRthNytoVlCYcRm6O0MxIz6cIUZvb2i/C
	aYeN4KvDUn3hBeNFbHesW3bVLVd8N8FzpuBtA=
MIME-Version: 1.0
In-Reply-To: <1306588052-sup-9838@brick>
References: <1306588052-sup-9838@brick>
Date: Wed, 1 Jun 2011 15:35:35 +1000
Message-ID: <BANLkTikEJ9dJ5kLg2QJQ+egHg2sh7S1wiA@mail.gmail.com>
Subject: Re: [python] get all messages of a thread
From: Brian May <brian@microcomaustralia.com.au>
To: Patrick Totzke <patricktotzke@googlemail.com>
Content-Type: multipart/alternative; boundary=bcaec52c5c8dce7d8804a49fe3bc
Cc: notmuch <notmuch@notmuchmail.org>
Precedence: list

--bcaec52c5c8dce7d8804a49fe3bc
Content-Type: text/plain; charset=ISO-8859-1

On 28 May 2011 23:18, Patrick Totzke <patricktotzke@googlemail.com> wrote:

>    if r: #because we cant iterate on NoneType
>

I don't understand why, but this line sets r._msgs to None. So it crashes,
because it has no message ids to look for.

If you change it to

if r is not None:

... then it works for me.

Oh, I see, for your code, there is a implied call to __len__, and the
__len__ function is completely broken for the reasons described in the
documentation:

      .. note:: As this iterates over the messages, we will not be able to=
               iterate over them again! So this will fail::

                 #THIS FAILS
                 msgs = Database().create_query('').search_message()
                 if len(msgs) > 0:              #this 'exhausts' msgs
                     # next line raises
NotmuchError(STATUS.NOT_INITIALIZED)!!!
                     for msg in msgs: print msg

               Most of the time, using the
               :meth:`Query.count_messages` is therefore more
               appropriate (and much faster). While not guaranteeing
               that it will return the exact same number than len(),
               in my tests it effectively always did so.



-- 
Brian May <brian@microcomaustralia.com.au>

--bcaec52c5c8dce7d8804a49fe3bc
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div class=3D"gmail_quote">On 28 May 2011 23:18, Patrick Totzke <span dir=
=3D"ltr">&lt;<a href=3D"mailto:patricktotzke@googlemail.com">patricktotzke@=
googlemail.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
=A0 =A0if r: #because we cant iterate on NoneType<br></blockquote><div><br>=
</div><div>I don&#39;t understand why, but this line sets r._msgs to None. =
So it crashes, because it has no message ids to look for.</div><div><br></d=
iv>
<div>If you change it to</div><div><br></div><div>if r is not None:</div><d=
iv><br></div><div>... then it works for me.=A0</div><div><br></div><div>Oh,=
 I see, for your code, there is a implied call to __len__, and the __len__ =
function is completely broken for the reasons described in the documentatio=
n:</div>
<div><br></div><div><div>=A0 =A0 =A0 .. note:: As this iterates over the me=
ssages, we will not be able to=3D</div><div>=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
iterate over them again! So this will fail::</div><div><br></div><div>=A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0#THIS FAILS</div>
<div>=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0msgs =3D Database().create_query(&#=
39;&#39;).search_message()</div><div>=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if =
len(msgs) &gt; 0: =A0 =A0 =A0 =A0 =A0 =A0 =A0#this &#39;exhausts&#39; msgs<=
/div><div>=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0# next line raises Not=
muchError(STATUS.NOT_INITIALIZED)!!!</div>
<div>=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0for msg in msgs: print msg<=
/div><div><br></div><div>=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0Most of the time, u=
sing the</div><div>=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0:meth:`Query.count_messag=
es` is therefore more</div><div>=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0appropriate =
(and much faster). While not guaranteeing</div>
<div>=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0that it will return the exact same numb=
er than len(),</div><div>=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0in my tests it effe=
ctively always did so.</div></div><div><br></div><div><br></div><div><br></=
div></div>-- <br>Brian May &lt;<a href=3D"mailto:brian@microcomaustralia.co=
m.au">brian@microcomaustralia.com.au</a>&gt;<br>


--bcaec52c5c8dce7d8804a49fe3bc--