From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [RFC] emacs: use ido completing read for address completion in
	message mode
Date: Thu, 12 Jul 2012 18:54:07 +0100
Message-Id: <1342115648-12147-1-git-send-email-markwalters1009@gmail.com>
Precedence: list

This patch uses ido-completing-read for address completion in message
mode.  Although ido-completing-read is nominally a drop-in replacement
for completing-read `initial` and `default` behave rather differently
and it makes sense to use `default` rather than `initial` in the ido
case.
---

There was some interest on irc for using ido-completing-read for
address completion in message-mode so here is a trivial patch.

I am not sure I like the ido-completing-read behaviour as typing in
the minibuffer matches anywhere in the address not just at the start
of the address. I think there is a difference between this and setting
the users from address where it is likely that many of their addresses
start the same.

But it might be a starting point for experiments.

Best wishes

Mark


 emacs/notmuch-address.el |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el
index 2bf762b..08e0e38 100644
--- a/emacs/notmuch-address.el
+++ b/emacs/notmuch-address.el
@@ -61,9 +61,9 @@ line."
 		  ((eq num-options 1)
 		   (car options))
 		  (t
-		   (completing-read (format "Address (%s matches): " num-options)
-				    (cdr options) nil nil (car options)
-				    'notmuch-address-history)))))
+		   (ido-completing-read (format "Address (%s matches): " num-options)
+				    (cdr options) nil nil nil
+				    'notmuch-address-history (car options))))))
     (if chosen
 	(progn
 	  (push chosen notmuch-address-history)
-- 
1.7.9.1