Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 8003A431FBC
	for <notmuch@notmuchmail.org>; Fri, 29 Mar 2013 08:54:36 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id gXbm3fTOwRqV for <notmuch@notmuchmail.org>;
	Fri, 29 Mar 2013 08:54:35 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id C4FC4431FAF
	for <notmuch@notmuchmail.org>; Fri, 29 Mar 2013 08:54:35 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 78F85100033;
	Fri, 29 Mar 2013 17:54:33 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: introduce notmuch-command-to-string,
	replace use of shell-command-to-string
In-Reply-To: <87vc8ai6gt.fsf@maritornes.cs.unb.ca>
References: <874nguxbvq.fsf@tu-dortmund.de>
	<1362747878-3571-1-git-send-email-david@tethera.net>
	<87vc8ai6gt.fsf@maritornes.cs.unb.ca>
User-Agent: Notmuch/0.15.2+50~g43fdda5 (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Fri, 29 Mar 2013 17:54:33 +0200
Message-ID: <m2eheyw69y.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Mar 2013 15:54:36 -0000

On Fri, Mar 29 2013, David Bremner <david@tethera.net> wrote:

> david@tethera.net writes:
>
>> From: David Bremner <bremner@debian.org>
>>
>> This has two benefits: unified error handling, and avoiding tramp's
>> hooking into shell-command-string.
>>
>> This seems to be a fix for id:874nguxbvq.fsf@tu-dortmund.de
>> ---
>>
>> Simon: can you check if this fixes your bug?
>
> Anyone willing to sanity check my e-lisp?

LGTM. The implementation is quite much the same as in 
notmuch-call-notmuch-process, just that this function returns
the output as a string.

> d

Tomi