Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 97BC7431FD0 for ; Sat, 31 Dec 2011 19:22:57 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NwDwkeKm82IQ for ; Sat, 31 Dec 2011 19:22:57 -0800 (PST) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 1B58A431FB6 for ; Sat, 31 Dec 2011 19:22:57 -0800 (PST) Received: from zancas.localnet (fctnnbsc36w-156034079193.pppoe-dynamic.High-Speed.nb.bellaliant.net [156.34.79.193]) (authenticated bits=0) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id q013MrkE017589 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO) for ; Sat, 31 Dec 2011 23:22:53 -0400 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1RhC0a-0002D3-PE for notmuch@notmuchmail.org; Sat, 31 Dec 2011 23:22:52 -0400 From: David Bremner To: notmuch@notmuchmail.org Subject: revised patch for gmime init, with test. Date: Sat, 31 Dec 2011 23:22:46 -0400 Message-Id: <1325388169-8444-1-git-send-email-david@tethera.net> X-Mailer: git-send-email 1.7.7.3 In-Reply-To: <1325306261-21444-2-git-send-email-kaz.rag@gmail.com> References: <1325306261-21444-2-git-send-email-kaz.rag@gmail.com> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jan 2012 03:22:57 -0000 It turns out that our existing (trivial) python test is enough to catch this bug, but the corpus needs to be augmented. This augmentation is a bit intrusive so I'm thinking of cherry-picking only the actual fix to the release branch. Unfortunately the test message is 8 bit, so it may be encoded in some inconvenient way for patch application. The message is attached to an earlier message in the thread if you want to double check. I also wondered about putting g_type_init inside the (!initialized) test, but decided against it on the grounds of minimality. I think we want to in the medium term factor out all of the initialization code into one (probably private) function; we can clean things up a bit more then.