Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C9BEC431FBD for ; Mon, 7 Dec 2009 22:26:23 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zmgmYqsNFuzL for ; Mon, 7 Dec 2009 22:26:23 -0800 (PST) Received: from megan.quadhome.com (megan.quadhome.com [209.9.237.126]) by olra.theworths.org (Postfix) with ESMTP id EB0CC431FAE for ; Mon, 7 Dec 2009 22:26:22 -0800 (PST) Received: from elise.quadhome.com (c-98-232-103-76.hsd1.wa.comcast.net [98.232.103.76]) by megan.quadhome.com (Postfix) with ESMTPSA id 61AE31083BD for ; Mon, 7 Dec 2009 22:26:21 -0800 (PST) Content-Type: text/plain; charset=UTF-8 From: Scott Robinson To: notmuch In-reply-to: <1260242088-15680-1-git-send-email-david@tethera.net> References: <1260124225-10830-1-git-send-email-david@tethera.net> <1260242088-15680-1-git-send-email-david@tethera.net> Date: Mon, 07 Dec 2009 22:26:19 -0800 Message-Id: <1260253534-sup-1514@lisa> User-Agent: Sup/git Content-Transfer-Encoding: 8bit Subject: Re: [notmuch] [PATCH] notmuch-restore.c: only update tags for messages that differ from dump file. X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2009 06:26:24 -0000 Excerpts from david's message of Mon Dec 07 19:14:48 -0800 2009: > The patch allocates a temporary array to keep track of the current > list of tags using calloc and grows it as neccesary using realloc. The codebase has already well established the use of the talloc library. Why did you break with that? -- Scott Robinson | http://quadhome.com/ Q: Why are my replies five sentences or less? A: http://five.sentenc.es/