Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3C8EC429E29 for ; Tue, 10 May 2011 02:12:46 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eZiS2-MsM6DT for ; Tue, 10 May 2011 02:12:45 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id E6D34429E27 for ; Tue, 10 May 2011 02:12:44 -0700 (PDT) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id 4882766E0541; Tue, 10 May 2011 02:12:43 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from servo.finestructure.net (cpe-98-149-172-122.socal.res.rr.com [98.149.172.122]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id 3EE3466E0211; Tue, 10 May 2011 02:12:40 -0700 (PDT) Received: by servo.finestructure.net (Postfix, from userid 1000) id B12DEE46; Tue, 10 May 2011 02:12:40 -0700 (PDT) From: Jameson Graef Rollins To: Dmitry Kurochkin , Notmuch Mail Subject: Re: [PATCH] test: use `princ' instead of `message' calls in emacs tests In-Reply-To: <1305008708-15610-1-git-send-email-dmitry.kurochkin@gmail.com> References: <1305008708-15610-1-git-send-email-dmitry.kurochkin@gmail.com> User-Agent: Notmuch/0.6 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Tue, 10 May 2011 02:12:40 -0700 Message-ID: <877h9yncl3.fsf@servo.factory.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2011 09:12:46 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 10 May 2011 10:25:08 +0400, Dmitry Kurochkin wrote: > The patch replaces all (message (buffer-string)) calls in emacs > tests with (princ (buffer-string)). This avoids accidentally > interpreting '%' as format specifiers and makes code simpler > because we do not need to capture stderr. >=20 > Also, the patch works around an Emacs (23.3+1-1 on current Debian > Unstable) segfault in "Ensure that emacs doesn't drop results" > test. Note: the segfault does not happen on every test run. > Though, it seems to be consistently reproducible if the test uses > 300 messages instead of 30. Hopefully, it is the crash described > in Emacs bug #8545 [1] which is already fixed. This is a great catch, Dmitry. Thank you. And I'm glad you and Austin figured out the best solution. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJNyQGIAAoJEO00zqvie6q85w4P/2xtnY98fXNbOuZAlsGefIwV uZ36qWjLeqYglmtTFWWDmsjojtK1KUnYQ1yLnAJgEyMMZFkzb1FAWsE7gtfA/htD 9CyMiESLXHSqj92jnRv4a573cD8GIZeYMP+uvNA4tddf3jQvHWBU8jH3nTz2d4JY zZVNJ+ehA2TTYR8ERUym7jr9POt+cD+xm6pKJk5p8Qwmd2cYhK/iNf5egKE5s2m1 65CuAZoppVIkMcQiAT9Mw7dean8OwooQiL1MdWraW9UKVibaZPURQGOuq8IU1TrC L54yRWU+tNumT19GqRXJPmbrlMSJ8OFCxqthIWMsi5RQJJOK7koezO9GcTdGULGO joeEsxvzH40m4nim7ofX/RYW9wF6RlXQaahmsTzssgAgXKkNio3og4UkB/78wDNG WmTP9TeVDK7Agi7/HMuDLFn5TW0whNdDF3OMT4lukGgqauBicTM2+D/5BxeI4nop SJtzHdow20zdS/j+gXHywDyb0yf+LdgZ5ISbBcBFIvlQiGERtKxMTvP+DJ6cudMx RlPJGggxBnzi6KrGmQe1JPG/TyuluZQEFXPcCpocRNo7C+keWLOyC1jPTd8lBLmN Z8+dAO0ihRhwsXnWReke3aZnnLO9yv2t/l4PgB9rh4jMjPhoZG1fpc8+oAHum2Hw SvFqvJZ+cffrBO1ypp1K =usgQ -----END PGP SIGNATURE----- --=-=-=--