Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8981E429E25 for ; Mon, 27 Jun 2011 13:32:15 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y0ZdjYdgnW23 for ; Mon, 27 Jun 2011 13:32:15 -0700 (PDT) Received: from mail-qw0-f53.google.com (mail-qw0-f53.google.com [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 1AC8E431FD0 for ; Mon, 27 Jun 2011 13:32:15 -0700 (PDT) Received: by qwb7 with SMTP id 7so3043673qwb.26 for ; Mon, 27 Jun 2011 13:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=PUfVIBIhCL7UaFuj7714WRbwnfs4LlqFM1o+VmhieNM=; b=oeuOBBQDP55JECwu0aFFNJBjagBDO54m85jzCXyhkC2wIW8x/QvSWMY3zvFF7JNVv6 Ixt+UNQB2xoMswnke4Mfxz2kCjFfZrS/eBC4FqfRAj9rhlizu6+TTzEPEEM7yn06JiSt 13BM0tUL00AspMqKb9HmQ+9uiJsjLiEsLMTnU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=qtWfR74FophlxUqkwHm5+nJcO3J+fbzxX8mb9LZjkmK5nZvLZj1HKapkvtAkf3ME5X uBzWXnzr2z9u52a8AD1JO94Ygu9hSUgTdP2DPv2/2rcu6MgTzk7sG2xLw59BMSGkTkMO QizrtdFcQyJb49JwoAvyTFZJXSOl66z/TsuX4= MIME-Version: 1.0 Received: by 10.229.2.157 with SMTP id 29mr5076692qcj.62.1309206734232; Mon, 27 Jun 2011 13:32:14 -0700 (PDT) Sender: amdragon@gmail.com Received: by 10.229.32.197 with HTTP; Mon, 27 Jun 2011 13:32:14 -0700 (PDT) In-Reply-To: <87hb7byqge.fsf@gmail.com> References: <1309132379-24089-1-git-send-email-dmitry.kurochkin@gmail.com> <1309146846-30991-1-git-send-email-dmitry.kurochkin@gmail.com> <1309146846-30991-2-git-send-email-dmitry.kurochkin@gmail.com> <87hb7byqge.fsf@gmail.com> Date: Mon, 27 Jun 2011 16:32:14 -0400 X-Google-Sender-Auth: i7EteXgwKyQoDgvVlkzzY6v86uA Message-ID: Subject: Re: [PATCH 2/2] test: use emacsclient(1) for Emacs tests From: Austin Clements To: Dmitry Kurochkin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 20:32:15 -0000 On Mon, Jun 27, 2011 at 4:22 PM, Dmitry Kurochkin wrote: > On Mon, 27 Jun 2011 16:02:12 -0400, Austin Clements wr= ote: >> =A0The trap is there just to cleanly shut down in case of a normal >> exit [1]. > > For normal exit we should just put this into test_done. =A0Otherwise it i= s > not a normal exit and we do not care about Emacs error message. =A0No? Yes, that's good, too, and it avoids the standard pitfalls of trap.