Return-Path: <telenczuk@unic.cnrs-gif.fr>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 3A555431FC9
	for <notmuch@notmuchmail.org>; Mon,  2 Feb 2015 15:44:09 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 2.438
X-Spam-Level: **
X-Spam-Status: No, score=2.438 tagged_above=-999 required=5
	tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id nKLOUcP-YAy9 for <notmuch@notmuchmail.org>;
	Mon,  2 Feb 2015 15:44:06 -0800 (PST)
Received: from smtp.webfaction.com (mail6.webfaction.com [74.55.86.74])
	by olra.theworths.org (Postfix) with ESMTP id 16D78431FC7
	for <notmuch@notmuchmail.org>; Mon,  2 Feb 2015 15:44:06 -0800 (PST)
Received: from localhost (87-231-242-54.rev.numericable.fr [87.231.242.54])
	by smtp.webfaction.com (Postfix) with ESMTP id EED5B2094A20;
	Mon,  2 Feb 2015 23:44:03 +0000 (UTC)
Date: Tue, 03 Feb 2015 00:44:02 +0100
From: Bartosz Telenczuk <telenczuk@unic.cnrs-gif.fr>
To: Franz Fellner <alpine.art.de@gmail.com>, 
	Bartosz Telenczuk <telenczuk@unic.cnrs-gif.fr>
Message-ID:
 <54d00bc27077f_47c3ff0b58781fca5@bartels-MacBook-Pro.local.notmuch>
In-Reply-To: <54bff5c426e50_5b9d145d304d6@TP_L520.notmuch>
References: <1412618116-27586-1-git-send-email-imain@stemwinder.org>
	<1413828111-2879-1-git-send-email-imain@stemwinder.org>
	<54b45d071fd20_7f93fe5bd4401f087@bts-MacBook-Pro.local.notmuch>
	<54bff5c426e50_5b9d145d304d6@TP_L520.notmuch>
Subject: RE: [PATCH v3] VIM: Improve moving between messages in a thread
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Feb 2015 23:44:09 -0000

> I think the API should be clear and easy to understand, because people will probably bind them to custom shortcuts. You should not have to think about what that weird extra parameter (-1, false, ...) means and go read the docs.

I agree. One might replace the parameter with a string like "prev" and "next".

> But I agree that the code duplication is not optimal. The code in Ians repo already has split out the ruby code. There is still code duplication. But that can easily be split out into a function on its own. 

That's the way to go.

Bartosz