Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id F32E0431FAF for ; Tue, 10 Apr 2012 01:26:02 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.001 X-Spam-Level: X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 tests=[FAKE_REPLY_C=0.001] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vSr9D+ZymdtO for ; Tue, 10 Apr 2012 01:25:54 -0700 (PDT) Received: from upsilon.hackadomia.org (upsilon.hackadomia.org [91.121.245.170]) by olra.theworths.org (Postfix) with ESMTP id A717F431FAE for ; Tue, 10 Apr 2012 01:25:54 -0700 (PDT) Received: from usha.takhisis.invalid (zack.inria.fr [128.93.60.82]) by upsilon.hackadomia.org (Postfix) with ESMTPSA id 6992210055; Tue, 10 Apr 2012 10:25:52 +0200 (CEST) Received: by usha.takhisis.invalid (Postfix, from userid 1000) id 4966B68079E; Tue, 10 Apr 2012 10:25:52 +0200 (CEST) Date: Tue, 10 Apr 2012 10:25:52 +0200 From: Stefano Zacchiroli To: Taylor Carpenter Subject: Re: [PATCH] replace gnu xargs usage in notmuch-mutt with perl Message-ID: <20120410082552.GA10872@upsilon.cc> Mail-Followup-To: notmuch@notmuchmail.org, Stefano Zacchiroli MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.21 (2010-09-15) Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2012 08:26:03 -0000 Hi Taylor, thanks for your patch. It makes sense to me, and has the beneficial side effect of avoiding a sed pass to do some poor men shell escaping. Before applying, however, can you please update it to: - include a reasonable comment (as suggested by David) - avoid patching the shebang line (ditto) - coalesce the sprintf() line into the following symlink line (using sprintf seems redundant here: it's plain string concatenation) Thanks! Cheers. PS please Cc:-me on replies -- Stefano Zacchiroli zack@{upsilon.cc,pps.jussieu.fr,debian.org} . o . Maître de conférences ...... http://upsilon.cc/zack ...... . . o Debian Project Leader ....... @zack on identi.ca ....... o o o « the first rule of tautology club is the first rule of tautology club »