Message-ID: <4ede002a.0922cc0a.207d.3460@mx.google.com>
Content-Type: multipart/mixed; boundary="===============1876771212=="
MIME-Version: 1.0
References:
 <1318198374-926-1-git-send-email-4winter@informatik.uni-hamburg.de>
	<1318198374-926-2-git-send-email-4winter@informatik.uni-hamburg.de>
	<4eddf2b1.4288980a.0b74.5557@mx.google.com> <87mxb66jit.fsf@SSpaeth.de>
To: Sebastian Spaeth <Sebastian@SSpaeth.de>,
	Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org
In-Reply-To: <87mxb66jit.fsf@SSpaeth.de>
From: Patrick Totzke <patricktotzke@googlemail.com>
Subject: Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types
Date: Tue, 06 Dec 2011 11:44:01 +0000
Precedence: list

--===============1876771212==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

yes, i can. here's how to reproduce it on master:

fire a `notmuch tag +TEST1 '*'`, which should block the db for a while.
Then use the attached script to write to the index (this could make a nice
second testcase for the bindings in case the test body is large enough).

On master, the script fails like this:

A Xapian exception occurred opening database: Unable to get write lock on
/home/pazz/mail/.notmuch/xapian: already locked
Segmentation fault

When you reset using `git reset e92b438f46a3a` (to 4winters first patch), t=
he script
fails like this, which is the intended behaviour:

A Xapian exception occurred opening database: Unable to get write lock on /=
home/pazz/mail/.notmuch/xapian: already locked
Traceback (most recent call last):
  File "./p.py", line 3, in <module>
    db =3D notmuch.Database(mode=3Dnotmuch.Database.MODE.READ_WRITE)
  File "/usr/local/lib/python2.7/dist-packages/notmuch/database.py", line 1=
21, in __init__
    self.open(path, mode)
  File "/usr/local/lib/python2.7/dist-packages/notmuch/database.py", line 1=
73, in open
    raise NotmuchError(message=3D"Could not open the specified database")
notmuch.globals.NotmuchError: Could not open the specified database


best,
/p


Quoting Sebastian Spaeth (2011-12-06 11:12:42)
>On Tue, 06 Dec 2011 10:46:31 +0000, Patrick Totzke <patricktotzke@googlema=
il.com> wrote:
>> This commit breaks raising XapianErrors for me.
>> =

>> If I lock the index with some `notmuch tag +test '*'`
>> and try to write to it in alot, i get a segfault and
>> the following on stderr:
>> =

>> Xapian exception occurred opening database: Unable to get write lock on
>> /home/pazz/mail/.notmuch/xapian: already locked
>
>Can you confirm that this only occurs with this patch and not without?
>To be honest, I don't see how the patch would change things in a way
>that make it throw XapianErrors that would not also occur before this
>patch.
>
>Sebastian

--===============1876771212==
Content-Type: text/x-python; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="exceptiontest.py"

#!/usr/bin/python
import notmuch
db = notmuch.Database(mode=notmuch.Database.MODE.READ_WRITE)
q_new = notmuch.Query(db, '*')
for m in q_new.search_messages():
    m.add_tag('TEST')

--===============1876771212==--