Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E7F06431FB6 for ; Wed, 6 Feb 2013 09:51:10 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ctryD9fRmJgu for ; Wed, 6 Feb 2013 09:51:07 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id E44C1431FAF for ; Wed, 6 Feb 2013 09:51:06 -0800 (PST) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id 69B9166E01EB; Wed, 6 Feb 2013 09:51:06 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (adsl-76-240-184-246.dsl.irvnca.sbcglobal.net [76.240.184.246]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id 5FD2766E01C9; Wed, 6 Feb 2013 09:51:03 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id E9E60616F3; Wed, 6 Feb 2013 09:51:00 -0800 (PST) From: Jameson Graef Rollins To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH 0/6] notmuch cli config changes In-Reply-To: References: User-Agent: Notmuch/0.15+8~gd4a7374 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Wed, 06 Feb 2013 09:50:58 -0800 Message-ID: <871ucts54t.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2013 17:51:11 -0000 --=-=-= Content-Type: text/plain On Tue, Jan 29 2013, Jani Nikula wrote: > Hi all, the goal here is to add support for --config=FILE option at the > notmuch top level (e.g. 'notmuch --config=FILE search foo'). In order to > achieve this neatly, I ended up moving config open/close to main() from > subcommands. This isn't a bad thing, because all notmuch commands opened > the config file anyway. Hi, Jani. I appreciate you've put a lot of work into this series, but I'll be the same devil's advocate that I was to David previously. Why do we need a command line option here when we already have an environment variable that handles just this? Is there some benefit to having a command line option for this that I don't see? I see this as another instance of an option that regular users will rarely use, if ever. In general, I am a strong advocate of keeping the CLI slim. IMHO, adding more options makes the interface clunkier, and the manual harder to parse, and I'm against adding things that a normal user would likely never use. In retrospect, I should have had the same objection to the --format-version option, which I think could have just been an env var as well. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJREpgCAAoJEO00zqvie6q82nIQAJ3+KgJwC9kXm10pMmcTS2jS tfKBMIeAYkFG/cAMEwzshiFtw0Nlr/+2NhitfOg8D+g9Tpa9luBr01IzdLSEA6ww YJXrWwzRBwMdUaNDibi1MWZdPuYDceqJBpLWXKsKx9B1BoM53HK2P9DG1m1NZ5kl 7PotcbAHlD8L69oeym4DNkjHrNkib0c3LcbH0OqHosOXRqzRtxk9KzOp4cXCBJCU xsoSAKjcCZPwsV4hYVfRBYFnlSaJj5F6vdwAszMLef9fxk4s9q4HyqRHldG3ts06 39ZQ+nKu0YQuLGRJGsev1+vticAjPhMkiD32BApyeFo57mfca/itRORwsNs1pBRn wqpQoXFQm8f/Smaj55rADdI9bCHFWUh+sm6BK/PQR7FqBlFUyH/CK6LZSG+426Sj Vvs4uUxVACyu+z4eNkL2aDV22yIhfDHm00P7vrms8zVb/UOxh5Y4qNNZJSh5chOX fuN5uANthFX5lHQaWZc/xxpb/Mthauqgz/PF+6DV80PuvGSf1cnAMt2WsQUCrBz7 rOTyxlyh2UFiJDTp6ZqcA0ArOB4jzrdy43C1RsIWAyH76Yosy1Qz7PXaLb5h+a1n Z/klCPFCCf4iXK0qtqyBm2fJi4usAQHdYz49tfaGckcx4XZwg6L+57DG7F1KgyWc 4xw7EoMgU+JRtPYJwlX6 =AH8n -----END PGP SIGNATURE----- --=-=-=--