Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 291A5431FD0 for ; Fri, 30 Dec 2011 18:56:03 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vKIwkYHw0G09 for ; Fri, 30 Dec 2011 18:56:02 -0800 (PST) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 98BF6431FB6 for ; Fri, 30 Dec 2011 18:56:02 -0800 (PST) Received: from zancas.localnet (fctnnbsc36w-156034079193.pppoe-dynamic.High-Speed.nb.bellaliant.net [156.34.79.193]) (authenticated bits=0) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id pBV2u0jm027039 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Fri, 30 Dec 2011 22:56:00 -0400 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1Rgp71-0001p4-TZ; Fri, 30 Dec 2011 22:55:59 -0400 From: David Bremner To: Kazuo Teramoto , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init In-Reply-To: <1325282290-29565-2-git-send-email-kaz.rag@gmail.com> References: <877h1e6r9d.fsf@zancas.localnet> <1325282290-29565-1-git-send-email-kaz.rag@gmail.com> <1325282290-29565-2-git-send-email-kaz.rag@gmail.com> User-Agent: Notmuch/0.11~rc1 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 30 Dec 2011 22:55:59 -0400 Message-ID: <87k45d5u0w.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Dec 2011 02:56:03 -0000 On Fri, 30 Dec 2011 19:58:09 -0200, Kazuo Teramoto wrote: > g_mime_init already check for multiple initializations. > --- > lib/index.cc | 4 ---- > lib/message-file.c | 4 ---- > 2 files changed, 0 insertions(+), 8 deletions(-) Is this needed to fix the bug? It seems less futureproof to rely on gmime to check for double initialization if we don't have to. d