Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E36B3431FAE for ; Tue, 22 May 2012 13:48:02 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 1.274 X-Spam-Level: * X-Spam-Status: No, score=1.274 tagged_above=-999 required=5 tests=[RDNS_NONE=1.274] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LxOgpesY2OUT for ; Tue, 22 May 2012 13:48:01 -0700 (PDT) Received: from guru.guru-group.fi (unknown [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 2D8E9431FBC for ; Tue, 22 May 2012 13:48:01 -0700 (PDT) Received: by guru.guru-group.fi (Postfix, from userid 501) id 462A9100641; Tue, 22 May 2012 23:48:00 +0300 (EEST) From: Tomi Ollila To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH 0/9] Fix directory lookup on read-only databases In-Reply-To: <1337314423-3702-1-git-send-email-amdragon@mit.edu> References: <1337314423-3702-1-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.13~rc1+40~g96c989b (http://notmuchmail.org) Emacs/23.1.1 (x86_64-redhat-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2012 20:48:03 -0000 Austin Clements writes: > This fixes notmuch_database_get_directory and > notmuch_database_find_message_by_filename so that they don't attempt > to create missing directory documents. This makes them work on > read-only databases (and prevents n_d_f_m_b_f from crashing > unceremoniously on read-only databases). > > Unfortunately, there are several functions involved in directory > document lookup, so the first three patches simply add a creation flag > at each necessary layer. The remaining patches then fix up the two > API functions and their uses. > > If we do a 0.13.1 bug fix release, these patches could go in to > complement the API changes made in 0.13 to support these fixes. David > can make that call. > > There are several patches, but they're all short and incremental. This patch series looks good to me... Tomi > > bindings/python/notmuch/database.py | 11 ----------- > lib/database.cc | 40 +++++++++++++++++++++++++--------------- > lib/directory.cc | 41 +++++++++++++++++++++++++++++++++++------ > lib/message.cc | 11 +++++------ > lib/notmuch-private.h | 13 +++++++++++++ > lib/notmuch.h | 10 ++-------- > notmuch-new.c | 36 +++++++----------------------------- > test/python | 8 ++++++++ > 8 files changed, 95 insertions(+), 75 deletions(-) > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch