Date: Tue, 6 Nov 2012 14:35:22 +0100
From: Daniel <quite@hack.org>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes
Message-ID: <20121106133522.GA2029@kelebek.lublin.se>
References: <20121106001633.GA14918@kelebek.lublin.se>
	<87d2zro4qj.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87d2zro4qj.fsf@zancas.localnet>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: list

> > I came across it, having been annoyed by the fact that notmuch broke my reading
> > habits by marking messages (in the mutt sense) as seen, which I hadn't really
> > seen yet in mutt. I tried out the patch; it applied and seems to work. What can
> > I do to make it be applied? Other than giving it some attention. I must say
> > that I have zero insight in the test framework, but if that's what's needed
> > from me...
> 
> The patches need to be reviewed for correctness and style. Typically any
> non-trivial patch (or series) needs two reviews. You can see examples in
> the archives of how this works.  They are currently marked stale, which
> is supposed to mean they no long apply. On the other hand, if they apply
> for you, maybe that tagging is wrong (see http://notmuchmail.org/nmbug/
> for more information about patch tagging).

I'm completely new to the notmuch core (but have been a user of the alot and
emacs client for a while), and couldn't really say that they are completely
fine.

But they do apply (with some offset) to current master. They work, seem to do
what they say--and the test runs OK.

Thus I have now (after having been given access by David) removed
notmuch::stale and added notmuch::needs-review on the following:

2011-09-15 Louis Rilling
id:"1316039001-32602-4-git-send-email-l.rilling@av7.net"
  [PATCH 3/4] test: Adding non-maildir tags does not move message
id:"1316039001-32602-5-git-send-email-l.rilling@av7.net"
  [PATCH 4/4] tags_to_maildir_flags: Don't rename if no flags change

And reviewers?