Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 34524429E4A for ; Sat, 14 Jan 2012 01:20:35 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P09mmsYNplJ0 for ; Sat, 14 Jan 2012 01:20:34 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 837C5429E49 for ; Sat, 14 Jan 2012 01:20:34 -0800 (PST) Received: by wibhr12 with SMTP id hr12so1051405wib.26 for ; Sat, 14 Jan 2012 01:20:33 -0800 (PST) Received: by 10.180.24.105 with SMTP id t9mr7327837wif.19.1326532833284; Sat, 14 Jan 2012 01:20:33 -0800 (PST) Received: from localhost ([109.131.75.86]) by mx.google.com with ESMTPS id fq7sm14225669wbb.1.2012.01.14.01.20.32 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 14 Jan 2012 01:20:32 -0800 (PST) From: Pieter Praet To: David Edmondson , Jani Nikula Subject: Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." In-Reply-To: References: <87vcogketu.fsf@praet.org> <1326389586-21683-1-git-send-email-pieter@praet.org> User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Sat, 14 Jan 2012 10:18:46 +0100 Message-ID: <87hazyprpl.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2012 09:20:35 -0000 On Fri, 13 Jan 2012 16:06:17 +0000, David Edmondson wrote: > On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet wrote: > > Less code, same results, without sacrificing readability. > > Does this change correctly re-indent the line following the if/unless? It does... Or so I thought... I appear to have forgotten to correct the indentation @ `notmuch-hello-insert-tags'. Unfortunately git doesn't provide a way to diff the whitespace itself; (eg. "git diff --word-diff=color --word-diff-regex='[ \t]*'") Setting "color.diff.whitespace" (and perhaps expanding the scope of "core.whitespace") only colorizes *erroneous* whitespace... Does this really warrant a v2, or might we simply leave it as yet another victim for Tomi's uncrustify-for-elisp [1] ? Peace -- Pieter [1] id:"yf639bkexs3.fsf@taco2.nixu.fi"