Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 40EBB431FB6 for ; Mon, 18 Apr 2011 00:26:18 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 1.463 X-Spam-Level: * X-Spam-Status: No, score=1.463 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, RDNS_DYNAMIC=0.363, TO_NO_BRKTS_DYNIP=1] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5dGdSq9cKlMD for ; Mon, 18 Apr 2011 00:26:16 -0700 (PDT) Received: from xhlj.maillard.im (cha51-3-88-164-105-66.fbx.proxad.net [88.164.105.66]) by olra.theworths.org (Postfix) with ESMTP id 0B493431FB5 for ; Mon, 18 Apr 2011 00:26:16 -0700 (PDT) Received: from xhlj.maillard.im (xhlj.maillard.im [127.0.0.1]) by xhlj.maillard.im (Postfix) with ESMTP id CB1AF2C061; Mon, 18 Apr 2011 09:26:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=maillard.im; h=from:to :subject:in-reply-to:references:reply-to:date:message-id :mime-version:content-type; s=postfix; bh=xmUOvneqNOfcckU17O2SAM SK2Nc=; b=mO/NiqwzhNL/hpj54SsnRqx8sywa7ERQpWvQ0FxH3BwLwJ1SI4JdVe B69Eux9k3lHm9DgUBZvVMs9obJm8KG8kuUO43JGMSv0L40uXQ6drek/8jaYo9M+A c9TrW1zdkWf84FkpyVMi9erVhXpqk9nYepMHj6+BWopvWQsWu8Fl8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=maillard.im; h=from:to :subject:in-reply-to:references:reply-to:date:message-id :mime-version:content-type; q=dns; s=postfix; b=VaOtXRcYjWXbDWfk IZFhoBRA55M8H29p0AQXJfZmnwo+xncIBgdYNaxDfN/U5BidfemP73xEzsz1UTMp vIOI7WS/PXy4S1K6P9wXkBbNaaTUsgNUC4op30Rhuc56bxEIDHfuVX42DZteX5GE henj6d+NxBH1QsVWuoFsg0EEdyw= Received: from maillard.im (unknown [192.168.0.254]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by xhlj.maillard.im (Postfix) with ESMTPSA; Mon, 18 Apr 2011 09:26:12 +0200 (CEST) From: Xavier Maillard To: Pieter Praet , Kan-Ru Chen , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] emacs: notmuch-hello: Add "n" and "p" to mod map In-Reply-To: <87lizatjik.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me> References: <1280195325-9066-1-git-send-email-kanru@kanru.info> <1280195325-9066-3-git-send-email-kanru@kanru.info> <87lizatjik.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me> User-Agent: Notmuch/0.5-133-gc509598 (http://notmuchmail.org) Emacs/23.2.1 (i486-slackware-linux-gnu) Date: Mon, 18 Apr 2011 09:36:45 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Xavier Maillard List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 07:26:18 -0000 Hi Pieter, On Sat, 16 Apr 2011 15:26:11 +0200, Pieter Praet wrote: > On Tue, 27 Jul 2010 09:48:45 +0800, Kan-Ru Chen wrote: > > Bind "n" to widget-forward and "p" to widget-backward to unify the > > interface since other notmuch major mode also accept "n" and "p" to > > navigation. > > --- > > emacs/notmuch-hello.el | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el > > index 6ef03bb..7def241 100644 > > --- a/emacs/notmuch-hello.el > > +++ b/emacs/notmuch-hello.el > > @@ -294,6 +294,8 @@ should be. Returns a cons cell `(tags-per-line width)'." > > (define-key map "=" 'notmuch-hello-update) > > (define-key map "G" 'notmuch-hello-poll-and-update) > > (define-key map (kbd "") 'widget-backward) > > + (define-key map "n" 'widget-forward) > > + (define-key map "p" 'widget-backward) > > (define-key map "m" 'notmuch-mua-mail) > > (define-key map "s" 'notmuch-hello-goto-search) > > map) > > -- > > 1.7.1 > > > > > > > Sounds logical in theory, but in practice, you'll soon get stuck > spamming "nnnnnpppnwtf" in the search field. > > That, and TAB/S-TAB feels more natural. More natural than what exactly ? Anyway, that would not hurt to add 'n' and 'p' as another way to navigate through widgets in my opinion (whatsmore that's how customize also works -i.e navigation done both with TAB/S-TAB and n/p) /Xavier