From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: [PATCH] test: use dtach(1) instead of screen(1) in emacs tests.
Date: Thu, 10 Nov 2011 14:22:17 -0800
Message-Id: <1320963737-1666-1-git-send-email-jrollins@finestructure.net>
In-Reply-To: <yf6mxc3ab4t.fsf@taco2.nixu.fi>
References: <yf6mxc3ab4t.fsf@taco2.nixu.fi>
Precedence: list

From: Tomi Ollila <tomi.ollila@iki.fi>

dtach is lighter than screen and is not setuid/setgid program so
TMPDIR does not get reset by dynamic loader when executed.

Signed-off-by: Jameson Graef Rollins <jrollins@finestructure.net>
---
This tweaks the original patch slightly by removing the no-longer needed
screenrc variables.

 test/test-lib.sh |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/test/test-lib.sh b/test/test-lib.sh
index c81c709..c0fe037 100755
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -50,8 +50,6 @@ TZ=UTC
 TERM=dumb
 export LANG LC_ALL PAGER TERM TZ
 GIT_TEST_CMP=${GIT_TEST_CMP:-diff -u}
-export SCREENRC=/dev/null
-export SYSSCREENRC=/dev/null
 
 # Protect ourselves from common misconfiguration to export
 # CDPATH into the environment
@@ -844,7 +842,8 @@ test_emacs () {
 	if [ -z "$EMACS_SERVER" ]; then
 		EMACS_SERVER="notmuch-test-suite-$$"
 		# start a detached screen session with an emacs server
-		screen -S "$EMACS_SERVER" -d -m "$TMP_DIRECTORY/run_emacs" \
+		TERM=xterm dtach -n "$TMP_DIRECTORY/dtach-emacs-socket-$$" \
+			"$TMP_DIRECTORY/run_emacs" \
 			--no-window-system \
 			--eval "(setq server-name \"$EMACS_SERVER\")" \
 			--eval '(server-start)' \
-- 
1.7.7.1