DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:cc
	:content-type:content-transfer-encoding;
	b=o5l8Lse91W4w7ChvIzYPgnSzFvu7gsdclOAoy1oWMPBUDnIlLVmRpXnklPxelPDfb5
	LbMDfalIeiRgCx9d3wf3FbgZBM1GupGR4aTNRySt5+LHj+35yO/mS26HgVq8qXQRVHOh
	QiRu5iNupjQ0lVd7kjNk2JrexvISShwOnYkYQ=
MIME-Version: 1.0
In-Reply-To: <20101202151325.GI1775@blackspot>
References: <1291235272-16335-1-git-send-email-joel.borggren.franck@gmail.com>
	<20101202151325.GI1775@blackspot>
Date: Thu, 2 Dec 2010 17:33:04 +0100
Message-ID: <AANLkTinX7kTVeCsuyotTsswugC3ik3Ra8jE-t2qx7-n3@mail.gmail.com>
Subject: Re: [PATCH] test: change "#!/bin/bash" to "#!/usr/bin/env bash"
	enhances portability
From: =?ISO-8859-1?Q?Joel_Borggr=E9n=2DFranck?=
	<joel.borggren.franck@gmail.com>
Cc: notmuch@notmuchmail.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Thu, Dec 2, 2010 at 4:13 PM, Ruben Pollan <meskio@sindominio.net> wrote:
> On 21:27, Wed 01 Dec 10, Joel Borggr=E9n-Franck wrote:
>> From: Joel Borggr=E9n-Franck <jbf@codehouse.se>
>>
>> Change #!/bin/bash at start of tests to "#!/usr/bin/env bash". That way
>> systems running on bash < 4 can prepend bash >=3D 4 to path before
>> running the tests.
>
> Is there any reason to use bash? Is the test system dependent to any key =
feature
> of bash?
>
> Not every system has bash installed. To have a dependency on bash just fo=
r
> development I think is not a big issue. But if it don't requires any big =
effort
> I think will be better to have it more generic.
>

The test harness explicitly requires bash >=3D 4 . The docs say it needs
support for associative arrays.

cheers
/Joel