From: Michal Nazarewicz <mpn@google.com>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
 notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: notmuch-search: fix faces
In-Reply-To: <87ipc4jcfv.fsf@servo.finestructure.net>
Organization: Google Inc
References:
 <83882f4c8de5317e0184dc091a197b2341e5f015.1345725028.git.mina86@mina86.com>
	<87ipc4jcfv.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.14+2~g416b120 (http://notmuchmail.org) Emacs/24.2.50.1
	(x86_64-unknown-linux-gnu)
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC
Date: Tue, 28 Aug 2012 01:11:05 +0200
Message-ID: <xa1t3938ue0m.fsf@mina86.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

> On Thu, Aug 23 2012, Michal Nazarewicz <mpn@google.com> wrote:
>> For some reason the faces do not get applied when 'face property is
>> used, but they work correctly with 'font-lock-face property.  This
>> commit changes notmuch-search to use the latter.

Jameson Graef Rollins <jrollins@finestructure.net> writes:
> Hi, Michal.  Can you say a bit more about what's motivating this?  This
> feature seems to work fine for me, so I would like to understand what's
> not working for you.  I'm certainly no expert on emacs font handling,
> though, so maybe this is the proper thing to do.  Thanks.

I'm not an expert either, but with this patch applied I see colours,
without this patch, I don't see colours, ie. everything is rendered
using the default face.

I'm also not entirely sure if that's the correct way of doing things
since 'face seems to be working in other modes (most notably
notmuch-show).  By posting, I'm also hoping that someone more
experienced will maybe take a look to see what's going on here... ;)

For some more info, in notmuch-show mode, I get-text-property of nil for
both 'face and 'font-lock-face, but in message-mode or in *scratch*
buffer I'm getting nil for 'font-lock-face but non-nil for 'face.  With
the patch, I'm getting the same non-nil for both 'face and
'font-lock-face; without the patch, I'm getting nil for both.

--=20
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o
..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =
 (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
--=-=-=
Content-Type: multipart/signed; boundary="==-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--==-=-=
Content-Type: text/plain


--==-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBAgAGBQJQO/6JAAoJECBgQBJQdR/0akcQAIHv7HM1dpg8CdL91ZgHus10
k+QwrXnTyr3GoRsJrD3sPZEnXc1FxXFJbMNq+b+nBfsU6Ihjv8WpuqMP/K3amo5f
x3lEjsvnsUB8Is8/lvp3OuGW9l8+AhWphX6dB2n3uqUTy0w6xzurwB5JHEUG0Z+C
IHs45QfvVhkw7BEpV3o8FCDcP0letSbFg2ff2AnASFoHh8nykeVo1e/hjWp0qJao
t1nYwxjw2g000O81aNN6xxbbksfxlNWvquypnCmUIHbhBROLgaJKCKs6/MskEA30
BNuXsDB81TwVBcoyO83ttl1zU9CdCrq6cUkEYvQy8aZxn5Isn0jeg5vGnzh7mm3J
g5jIb3eohBX2MngafLqVGrCrzGolZjXqF+GekllDNuVUcfqXychhpiBRNE+XZ+2T
i8Hj/PTRCvTKRg/vIqCQma4cSo2qtJ0hMW0or7McNZ8XWne1tFPKqJ3It4qBFrqf
SKRZPD6V41X3U44sRQ+SQ6hTfyNHkOIVwGNVQ6ZPs84/x9J2JuUJ0FxQq26s9Ne2
7QLQaEdswBzvsdKS1+2AMvIXirq+mIFTIcrpjzaUWEgKcWTSO4o5t3l8s8VJ+wz2
iav9EAxIlxdXma6rnd2n3/ER+3RzUL361FI31v1/a2bEU1z1xRi/ihOzYHRpojz5
0yRaBPwWAwPQMXvyMjBz
=C4xR
-----END PGP SIGNATURE-----
--==-=-=--

--=-=-=--