Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7E7E2429E26 for ; Sat, 30 Jul 2011 14:47:01 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ov3o5IYHGF4I for ; Sat, 30 Jul 2011 14:47:00 -0700 (PDT) Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 53BBD429E25 for ; Sat, 30 Jul 2011 14:47:00 -0700 (PDT) Received: from taco2.nixu.fi (localhost [127.0.0.1]) by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id p6ULkvEB013386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sun, 31 Jul 2011 00:46:58 +0300 Received: (from too@localhost) by taco2.nixu.fi (8.14.3/8.14.3/Submit) id p6ULkvTL013385; Sun, 31 Jul 2011 00:46:57 +0300 X-Authentication-Warning: taco2.nixu.fi: too set sender to tomi.ollila@nixu.com using -f From: Tomi Ollila To: notmuch@notmuchmail.org Subject: patch: notmuch-mua.el -- message-hidden-headers X-Face: HhBM'cA~ User-Agent: Gnus/5.110014 (No Gnus v0.14) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jul 2011 21:47:01 -0000 notmuch-mua.el fails to byte-compile on emacs 22.2.1 The reason is bug in function notmuch-mua-add-more-hidden-headers; on emacs 23.x it compiles ok, but works incorrectly: The check which check whether the header is there already always returns nil. Examples: (setq foo (list "x" "foo" "bar")) (member "foo" 'foo) returns nil, (member "foo" foo) returns list ("foo" bar"), as expected. the former on emacs 22.2.1; backtrace buffer appears with content: Debugger entered--Lisp error: (wrong-type-argument listp foo) member("foo" foo) eval((member "foo" (quote foo))) eval-last-sexp-1(nil) eval-last-sexp(nil) call-interactively(eval-last-sexp) patch to fix this: diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index 274c5da..8824b08 100644 --- a/emacs/notmuch-mua.el +++ b/emacs/notmuch-mua.el @@ -65,7 +65,7 @@ list." (defun notmuch-mua-add-more-hidden-headers () "Add some headers to the list that are hidden by default." (mapc (lambda (header) - (when (not (member header 'message-hidden-headers)) + (when (not (member header message-hidden-headers)) (push header message-hidden-headers))) notmuch-mua-hidden-headers)) Tomi