Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 70E72429E21 for ; Wed, 11 Jan 2012 10:35:41 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 1.7 X-Spam-Level: * X-Spam-Status: No, score=1.7 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yPthmQ-MtPsc for ; Wed, 11 Jan 2012 10:35:41 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id D16B2431FB6 for ; Wed, 11 Jan 2012 10:35:40 -0800 (PST) Received: by bkat2 with SMTP id t2so783566bka.26 for ; Wed, 11 Jan 2012 10:35:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=zlOQcWQWrwWPbTyyWuwk5Utyn80SKSU4xx/ymQgHJ/8=; b=D7YKqMmfSoix19fEQm7idUiitBdMn/t5yp4435J7OvUZL1nPS4ak43CaVZ0cC7gFVW GpnZR/VIK5BBHQMtJ08/1L5aYnfJix+nihMT1V05F7f6M3OUWdHMa92uuM4/S/CFsyzG 3cy80wqrjuOHJeEwMJKAxL/2pKJVr4UgmXmm8= Received: by 10.204.151.69 with SMTP id b5mr57626bkw.14.1326306938000; Wed, 11 Jan 2012 10:35:38 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id b9sm4998375bks.6.2012.01.11.10.35.36 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 11 Jan 2012 10:35:36 -0800 (PST) From: Dmitry Kurochkin To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH] notmuch/emacs: Observe the charset of encoded parts, where known. In-Reply-To: <1326279001-28427-1-git-send-email-dme@dme.org> References: <1326279001-28427-1-git-send-email-dme@dme.org> User-Agent: Notmuch/0.10.2+135~gb811a3c (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Wed, 11 Jan 2012 22:34:45 +0400 Message-ID: <87k44ym6ka.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 18:35:41 -0000 -1 I already tried to solve the above problem using a more general approach (output all content-type parameters, not just charset) [1]. There was a lengthy discussion on IRC about it and it was rejected. The consensus was that we need to make some more substantial changes to JSON and raw output formats to properly fix the issue (and the issue is more general than what this patch fixes, other content-type parameters are useful for renderers as well and should be included in the output). One particular issue with your patch is that it adds (incorrect) charset parameter to plain/text parts which are converted to UTF-8 in JSON output. I am planning to work on a proper fix for this issue, but decided to postpone it until Austin's rewrite of notmuch show is complete. Regards, Dmitry [1] id:"1321659905-24367-1-git-send-email-dmitry.kurochkin@gmail.com"