Return-Path: <bremner@tesseract.cs.unb.ca>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 03C8B6DE01BA
 for <notmuch@notmuchmail.org>; Thu, 30 Jun 2016 01:40:46 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.005
X-Spam-Level: 
X-Spam-Status: No, score=-0.005 tagged_above=-999 required=5
 tests=[AWL=-0.006, HEADER_FROM_DIFFERENT_DOMAINS=0.001]
 autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id xmWjzgRfTqWR for <notmuch@notmuchmail.org>;
 Thu, 30 Jun 2016 01:40:38 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 075D06DE00BF
 for <notmuch@notmuchmail.org>; Thu, 30 Jun 2016 01:40:37 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
 (envelope-from <bremner@tesseract.cs.unb.ca>)
 id 1bIXWB-0007dx-Vn; Thu, 30 Jun 2016 04:40:16 -0400
Received: (nullmailer pid 30879 invoked by uid 1000);
 Thu, 30 Jun 2016 08:40:30 -0000
From: David Bremner <david@tethera.net>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: RFC: do what jamie wants with notmuch tag
Date: Thu, 30 Jun 2016 10:40:25 +0200
Message-Id: <1467276027-30633-1-git-send-email-david@tethera.net>
X-Mailer: git-send-email 2.8.1
In-Reply-To: <87fustdsx9.fsf@zancas.localnet>
References: <87fustdsx9.fsf@zancas.localnet>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jun 2016 08:40:46 -0000

The second patch in particular could be cleaned up; there is definitely some
duplication between the two code paths, so opening the database and
creating a query could/should be refactored.

It seems somewhat reasonable to have notmuch_query_search_tags in the
API. I would say just document the limitation of ignoring excludes
when querying for all tags, otherwise that optimization (which is a
huge speed improvement) will mostly be useless.