Date: Sat, 4 Jun 2011 13:07:32 -0700
From: Dima Kogan <notmuch@dima.secretsauce.net>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
Subject: Re: [PATCH] Added C-up and C-down to cycle through previous searches
Message-ID: <20110604130732.5d28fb68@smart>
In-Reply-To: <87vcwto5n3.fsf@gmail.com>
References: <1306659388-21809-1-git-send-email-notmuch@dima.secretsauce.net>
	<87vcwto5n3.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: notmuch@notmuchmail.org
Precedence: list

> On Sun, 29 May 2011 20:04:00 +0400
> Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
>
> Hi Dima.
> 
> On Sun, 29 May 2011 01:56:28 -0700, notmuch@dima.secretsauce.net
> wrote:
> > From: Dima Kogan <dima@secretsauce.net>
> > 
> > ---
> > 
> >  Hi.
> > 
> >  I made a few improvements to the emacs UI. This patch allows the
> > user to scroll through the most recent searches with C-up and
> > C-down while in the search box.
> > 
> 
> This sounds like a very nice improvement to me!  I just have one
> concern: Why C-up and C-down?  I believe M-p and M-n would be more
> natural for Emacs users (at least for me :)).
> 
> Also, I did not read the code and can not comment on it.  But notmuch
> coding style is to use tabs for indentation.  I guess .dir-locals.el
> should be improved to set coding style variables for all modes, not
> just C.
> 
> Regards,
>   Dmitry

Hi. I have a mild preference to C-up/down, but M-n/p is just fine also.
As for the coding style, I've looked through that file
(notmuch-hello.el), and it doesn't seem to have a consistent style as
far as tabs/spaces go. I'm happy to change my patch to conform, but I
don't know what I should be conforming to. Should I be tab-ing all
indents, or just some?