Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id CF95F431FAF for ; Thu, 9 Aug 2012 00:46:51 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YKHq9obJZGh9 for ; Thu, 9 Aug 2012 00:46:48 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 06AB7431FAE for ; Thu, 9 Aug 2012 00:46:48 -0700 (PDT) Received: by guru.guru-group.fi (Postfix, from userid 501) id 8DBEE1002A4; Thu, 9 Aug 2012 10:46:56 +0300 (EEST) From: Tomi Ollila To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: Fix "not defined at runtime" warning In-Reply-To: <1344462010-5349-1-git-send-email-amdragon@mit.edu> References: <1344462010-5349-1-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.13.2+128~g07453d8 (http://notmuchmail.org) Emacs/23.1.1 (x86_64-redhat-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2012 07:46:52 -0000 On Thu, Aug 09 2012, Austin Clements wrote: > Previously, the Emacs byte compiler produced the warning > > the function `remove-if-not' might not be defined at runtime. > > because we only required cl at compile-time (not runtime). This fixes > this warning by requiring cl at runtime, ensuring that the definition > of remove-if-not is available. > --- LGTM. It took me a while to understand this. Now I just don't understand how did this work before. And why (require 'cl) is enough as remove-if-not is defined in cl-seq.el -- cl-seq.el requires cl but not vice-versa -- or at least I don't see that. Anyway (require 'cl) is the common way. Tomi > emacs/notmuch-lib.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el > index 30db58f..900235b 100644 > --- a/emacs/notmuch-lib.el > +++ b/emacs/notmuch-lib.el > @@ -24,7 +24,7 @@ > (require 'mm-view) > (require 'mm-decode) > (require 'json) > -(eval-when-compile (require 'cl)) > +(require 'cl) > > (defvar notmuch-command "notmuch" > "Command to run the notmuch binary.") > -- > 1.7.10 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch