From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>, notmuch@notmuchmail.org
Subject: Re: [BUG/PATCH v2] emacs: Fix the References header in reply
In-Reply-To: <1332996818-15700-1-git-send-email-awg+notmuch@xvx.ca>
References: <1332991226-510-1-git-send-email-awg+notmuch@xvx.ca>
	<1332996818-15700-1-git-send-email-awg+notmuch@xvx.ca>
User-Agent: Notmuch/0.12+78~g127fa56 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Thu, 29 Mar 2012 10:14:47 -0700
Message-ID: <87aa2zjpmg.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Wed, Mar 28 2012, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:
> In the new reply code, the References header gets inserted by
> message.el using a function called message-shorten-references. Unlike
> all the other header-inserting functions, it doesn't put a newline
> after the header, causing the next header to end up on the same
> line. In our case, this header happened to be User-Agent, so it's hard
> to notice. This is probably a bug in message.el, but we need to work
> around it.
>
> This fixes the problem by wrapping message-shorten-references in a
> function that inserts a newline after if necessary. This should
> protect against the message.el bug being fixed in the future.

Hey, Adam.  Thanks so much for working on this.

I just tested this patch and it does seem to fix the issue.  However, a
side effect seems to be that the References header is now appearing as
the first header in the reply buffer, rather than the last, as it used
to.  I suppose this is merely aesthetic, but I did prefer the ordering
as it was before.  Is there a way to tweak the
message-header-format-alist so that the References header appears last
again?

Given the various things that are being affected by this, it would
probably be good to add a test for this as well.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJPdJiHAAoJEO00zqvie6q8kOMQAIUbXIrJtMolxvwdA9gw5mBk
KFtYfuCg236TXMu0hqHw68HDPNYRjhEc/8laHgbblq6Mq9WfrDJYfSqQKSiNc1wC
75Lj24t1eobRXNNqlFl4Y2BJC3q8DPolCif/+soeAM/D9yVq864g1q5hHOFBDWcp
7Zvf72DW6S11TZn/QH+oJxsDkLmFRGikDMEBIR0BHIZba5a8varGe+Qem496of7S
FYfwGXXGQnXigGKELjkxcQbtx3MLyolsZDj61hMsaC1Q6GeBaZShF3TAugBzcw/o
tQ2df4bMLt0IqWGUgMgHFFuenu/fYVSn0QU2nblrulDBqJiMQhmSYHLAORvel3in
QYzcTpn5d17vhlwIswudVTdci9sLmF+qfz92OGLYZKbx2c2V7rN6pG1KowvU7VMK
92S34pzgOj3YNwyhXWC1SKJbltaT/ov0pUpElmmNC8jy0d8GW39RGrWY9gmhEj3D
Z6a9T58Lzd4biBhkWBMzv7jgcwxY6aujUH91cI0dEgASP8fb+pOELSKOS4bzUXf7
pXk7tT48Mlh0ZIuKzHzJzrKr471F3xqPZUb1IwsoyDCjCP1wchPA6kRw/qZQU8tr
nP6/Jk415WsSfEQ1uhZV4QsIFkYMOSIOnDh90VQEjsNMIhRrB/FEWOoJI/X3/Ds3
j4o/36X+pQgzdfh91E4u
=J6sU
-----END PGP SIGNATURE-----
--=-=-=--