Date: Thu, 14 Feb 2013 15:06:51 -0800
From: "Kevin J. McCarthy" <kevin@8t8.us>
To: notmuch@notmuchmail.org
Subject: Re: notmuch-mutt: Use of uninitialized value.
Message-ID: <20130214230651.GA3247@zaogao.lan>
Mail-Followup-To: notmuch@notmuchmail.org, Stefano Zacchiroli
 <zack@upsilon.cc>
References: <20130212005801.GA8419@soarin> <20130213223535.GA3258@zaogao.lan>
	<20130213233657.GA4489@soarin> <20130214083713.GA4123@upsilon.cc>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="XsQoSWH+UP9D9v3l"
Content-Disposition: inline
In-Reply-To: <20130214083713.GA4123@upsilon.cc>
OpenPGP: id=B6B1CD9613699FB8;
	url=http://www.8t8.us/configs/13699FB8.asc.pubkey; preference=sign
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Stefano Zacchiroli <zack@upsilon.cc>
Precedence: list


--XsQoSWH+UP9D9v3l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Stefano Zacchiroli wrote:
> Right, but still a more graceful failure model would be nice.
>=20
> Please find attached a patch that in such cases should 1) give a
> supposedly nice error message explaining what's going on and 2) empty
> the results dir to avoid showing you unrelated results. It works for me.
> But extra checking never hurts, in particular for the tag action, which
> I don't personally use.

The patch works for me (for thread reconstruction - I don't use the
tagging features either).

> I guess it would also be nice to actually disable $pipe_decode in the
> relevant Mutt macros, but I'm not sure about to do that without
> interfering with user desired configuration. Kevin: do you know if there
> is a common Mutt trick to store the value of a variable before changing
> it, and restoring it a posteriori?  More isolation for this kind of
> things in Mutt would definitely be welcome...

It looks like this is possible, as Suvayu Ali mentioned too.  An
improvement to his example is also mentioned in the manual at
  http://www.mutt.org/doc/devel/manual.html#set-myvar
You can defer evaluation of the variables until runtime by prefixing
them with \$.

Here are some proposed improved macros.  (I'll attach a patch file in
another email.)  Despite my earlier warning about not line-breaking
macros, these are getting a bit unreadable.  We may want to see
if/where we can safely line-break them.

macro index <F8> \
      "<enter-command>set my_old_pipe_decode=3D\$pipe_decode my_old_wait_ke=
y=3D\$wait_key nopipe_decode nowait_key<enter><shell-escape>notmuch-mutt -r=
 --prompt search<enter><change-folder-readonly>`echo ${XDG_CACHE_HOME:-$HOM=
E/.cache}/notmuch/mutt/results`<enter><enter-command>set pipe_decode=3D\$my=
_old_pipe_decode wait_key=3D\$my_old_wait_key<enter>" \
      "notmuch: search mail"
macro index <F9> \
      "<enter-command>set my_old_pipe_decode=3D\$pipe_decode my_old_wait_ke=
y=3D\$wait_key nopipe_decode nowait_key<enter><pipe-message>notmuch-mutt -r=
 thread<enter><change-folder-readonly>`echo ${XDG_CACHE_HOME:-$HOME/.cache}=
/notmuch/mutt/results`<enter><enter-command>set pipe_decode=3D\$my_old_pipe=
_decode wait_key=3D\$my_old_wait_key<enter>" \
      "notmuch: reconstruct thread"
macro index <F6> \
      "<enter-command>set my_old_pipe_decode=3D\$pipe_decode my_old_wait_ke=
y=3D\$wait_key nopipe_decode nowait_key<enter><pipe-message>notmuch-mutt ta=
g -- -inbox<enter><enter-command>set pipe_decode=3D\$my_old_pipe_decode wai=
t_key=3D\$my_old_wait_key<enter>" \
      "notmuch: remove message from inbox"

-Kevin


--XsQoSWH+UP9D9v3l
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQEcBAEBCAAGBQJRHW4FAAoJELaxzZYTaZ+4rbEH/0wBFq9Pe4xSuXJW+Ev1htOg
uz+1w1uHO0yyM6lm/c7I3I1I0t9bZsqOv3eB0cdF2D1l1AzzwdjF6PmwXQXz4//5
lqdhN/1T4Zci0ToHSPjb4RfZoGXKoN6AmHhpn6wdkQ+1XsCKG19hEaCtSgdAtn2u
EvCuk3CsSUZ+trxj3ik9VlQlxzfjBkjDlMJ4NhhQm+6BAJegDWURI16Vo63rQPHU
m9FeNTslcGnY4a5zCnW/DpgjTCPNyfw+bCHxuXNMY5nTlUUU/BAW0lOKi+Ii8AjZ
IJwNVCRJQPN0Rx784ec8eCRNjAYEi3+tpVZAWMX5n47GJBoJphWu5LbEv9/uOBM=
=M3bF
-----END PGP SIGNATURE-----

--XsQoSWH+UP9D9v3l--