From: David Bremner <david@tethera.net>
To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] libnotmuch: build symbols list without relying on gcc
	-aux-info.
In-Reply-To: <87iprpaibc.fsf@yoom.home.cworth.org>
References: <1309136932-21910-1-git-send-email-david@tethera.net>
	<1309142545-30590-1-git-send-email-david@tethera.net>
	<87iprpaibc.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.6~238 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Tue, 28 Jun 2011 16:45:48 -0300
Message-ID: <87fwmtvixf.fsf@convex-new.cs.unb.ca>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Tue, 28 Jun 2011 12:04:39 -0700, Carl Worth <cworth@cworth.org> wrote:

> I assume by "better" you mean that this one is less fragile to issues
> like the precise formatting of our notmuch.h header file.

Yes, that's what I meant.

> Meanwhile, though, our API *is* declared in the header file, (that's
> what the header file exists for), so I do prefer to base our symbol list
> on it.

Sure, that makes sense to me.  I cherry-picked the sed patch to the
release branch.

> In fact, the ideal would probably be to take the objdump method and use
> it in the test suite to verify that its output matches the contents of
> notmuch.sym generated from the header file.

The second patch being turned into a test sounds like a great idea. I
can do that.

d



--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iJwEAQECAAYFAk4KL20ACgkQTiiN/0Um85lc/AQAocfF4AJ4TFxunk9tn/adG7mi
XthxmePUKl18cNnHdU35eKtSU1WsulfQevEsnwHA+1iwjgpfMSZnG/1DkrBBZB2L
PQJu2EfYGbD/jJJDJPudAUUi/6eERIIvawG+7pcx/CHt3qwLvQCqTUiX44LfjuyM
5Pi7t3NTXt2yOk0bXmg=
=BZDx
-----END PGP SIGNATURE-----
--=-=-=--