From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jani Nikula <jani@nikula.org>, Ben Gamari <bgamari.foss@gmail.com>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH 3/3] Add notmuch compact command
In-Reply-To: <87y5j42a03.fsf@nikula.org>
References: <1350487737-32058-1-git-send-email-bgamari.foss@gmail.com>
	<1350487737-32058-4-git-send-email-bgamari.foss@gmail.com>
	<87y5j42a03.fsf@nikula.org>
User-Agent: Notmuch/0.14+51~g62cd13b (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
Date: Thu, 18 Oct 2012 09:29:26 +0300
Message-ID: <m28vb41eex.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Wed, Oct 17 2012, Jani Nikula <jani@nikula.org> wrote:

> Nag nag nag: Commit message. ;)
>
> The custom is to have a man page for each notmuch cli command.
>
> Small nitpicks below.
>
>
> BR,
> Jani.
>
>
> On Wed, 17 Oct 2012, Ben Gamari <bgamari.foss@gmail.com> wrote:
>> ---
>>  Makefile.local    |    1 +
>>  notmuch-client.h  |    3 +++
>>  notmuch-compact.c |   43 +++++++++++++++++++++++++++++++++++++++++++
>>  notmuch.c         |    3 +++
>>  4 files changed, 50 insertions(+)
>>  create mode 100644 notmuch-compact.c
>>
>> diff --git a/Makefile.local b/Makefile.local
>> index 7f2d4f1..e050ba6 100644
>> --- a/Makefile.local
>> +++ b/Makefile.local
>> @@ -258,6 +258,7 @@ notmuch_client_srcs =3D		\
>>  	gmime-filter-headers.c	\
>>  	hooks.c			\
>>  	notmuch.c		\
>> +	notmuch-compact.c	\
>>  	notmuch-config.c	\
>>  	notmuch-count.c		\
>>  	notmuch-dump.c		\
>> diff --git a/notmuch-client.h b/notmuch-client.h
>> index ae9344b..a6c624b 100644
>> --- a/notmuch-client.h
>> +++ b/notmuch-client.h
>> @@ -157,6 +157,9 @@ int
>>  notmuch_cat_command (void *ctx, int argc, char *argv[]);
>>=20=20
>>  int
>> +notmuch_compact_command (void *ctx, int argc, char *argv[]);
>> +
>> +int
>>  notmuch_config_command (void *ctx, int argc, char *argv[]);
>>=20=20
>>  const char *
>> diff --git a/notmuch-compact.c b/notmuch-compact.c
>> new file mode 100644
>> index 0000000..6deb2ec
>> --- /dev/null
>> +++ b/notmuch-compact.c
>> @@ -0,0 +1,43 @@
>> +/* notmuch - Not much of an email program, (just index and search)
>> + *
>> + * Copyright =C2=A9 2009 Carl Worth
>
> It's your code, this year.

... but you can give copyright to Carl if you wish...

>> + *
>> + * This program is free software: you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation, either version 3 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program.  If not, see http://www.gnu.org/licenses/ .
>> + *
>> + * Author: Carl Worth <cworth@cworth.org>
>
> It's your code.

Yes, all the praise and blames ;)