From: Jani Nikula <jani@nikula.org>
To: Michal Nazarewicz <mina86@mina86.com>, David Bremner <david@tethera.net>,
	notmuch@notmuchmail.org
Subject: Re: =?utf-8?Q?=E2=80=98class_Xapian=3A=3ADatabase=E2=80=99?= has no
	member named =?utf-8?B?4oCYY2xvc2XigJk=?=
In-Reply-To: <xa1tk3x1psm2.fsf@mina86.com>
References: <xa1tsjbyd8v4.fsf@mina86.com>
 <87a9xx4yuj.fsf@maritornes.cs.unb.ca>	<xa1tk3x1psm2.fsf@mina86.com>
User-Agent: Notmuch/0.13.2+131~gff9267e (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Tue, 14 Aug 2012 14:57:13 +0200
Message-ID: <87fw7p1viu.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Tue, 14 Aug 2012, Michal Nazarewicz <mina86@mina86.com> wrote:
> Yeah, it seems that INSTALL claims =E2=80=9CNotmuch will work best with X=
apian
> 1.0.18 (or later) or Xapian 1.1.4 (or later)=E2=80=9D, which doesn't seem=
 to be
> the case.
>
> On top of that, configure does not seem to even check the version
> number.

Someone(tm) should fix both of the above.

> Is close() really required though?  The comment justifies it saying
> that:
>
> 	Many Xapian objects hold references to the database, so merely
> 	deleting the database may not suffice to close it.  Thus, we
> 	explicitly close it here.
>
> but wouldn't the database get closed when the last reference gets
> deleted anyway?

IIRC this was related to how closing is handled in the python
bindings. The close was introduced in the commit below, not too long
ago. I just reverted that one when I had to use notmuch with ancient
xapian (but the usual disclaimers apply).

BR,
Jani.


commit cfc5f1059aa16753cba610c41601cacc97260e08
Author: Justus Winter <4winter@informatik.uni-hamburg.de>
Date:   Fri Mar 2 15:58:39 2012 +0100

    Actually close the xapian database in notmuch_database_close
=20=20=20=20
    Formerly the xapian database object was deleted and closed in its
    destructor once the object was garbage collected. Explicitly call
    close() so that the database and the associated lock is released
    immediately.
=20=20=20=20
    The comment is a courtesy of Austin Clements.
=20=20=20=20
    Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>