Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 500FC431FC7 for ; Wed, 21 Aug 2013 10:08:52 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Amavis-Alert: BAD HEADER SECTION, Improper folded header field made up entirely of whitespace (char 20 hex): X-Spam-Report: ...T_ADDRESS@@ for details.\n \n Content previ[...] X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9AfmLlHpbkXi for ; Wed, 21 Aug 2013 10:08:46 -0700 (PDT) Received: from mail.nullprogram.com (mail.nullprogram.com [192.241.191.137]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id EB2B9431FAF for ; Wed, 21 Aug 2013 10:08:45 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=wellocc1-ld1.jhuapl.edu) by mail.nullprogram.com with esmtp (Exim 4.80) (envelope-from ) id 1VCBX1-0003PH-Ko; Wed, 21 Aug 2013 16:45:15 +0000 From: Christopher Wellons To: notmuch@notmuchmail.org Subject: [PATCH] Switch to DEF from INITIAL-INPUT in completing-read. Date: Wed, 21 Aug 2013 12:44:48 -0400 Message-Id: <1377103488-7425-1-git-send-email-wellons@nullprogram.com> X-Mailer: git-send-email 1.8.4.rc3 Cc: Christopher Wellons X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Aug 2013 17:08:52 -0000 As stated in the Emacs documentation, the initial-input argument is deprecated because it presents a poor interface to the user. In fact, with my setup where ido replaces completing-read, it's nearly unusable with initial-input. http://www.gnu.org/software/emacs/manual/html_node/elisp/Initial-Input.html --- emacs/notmuch-address.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el index fa65cd5..e89200b 100644 --- a/emacs/notmuch-address.el +++ b/emacs/notmuch-address.el @@ -42,11 +42,11 @@ to know how address selection is made by default." :group 'notmuch-send :group 'notmuch-external) -(defun notmuch-address-selection-function (prompt collection initial-input) +(defun notmuch-address-selection-function (prompt collection def) "Call (`completing-read' - PROMPT COLLECTION nil nil INITIAL-INPUT 'notmuch-address-history)" + PROMPT COLLECTION nil nil nil 'notmuch-address-history DEF)" (completing-read - prompt collection nil nil initial-input 'notmuch-address-history)) + prompt collection nil nil nil 'notmuch-address-history def)) (defvar notmuch-address-message-alist-member '("^\\(Resent-\\)?\\(To\\|B?Cc\\|Reply-To\\|From\\|Mail-Followup-To\\|Mail-Copies-To\\):" -- 1.8.4.rc3