MIME-Version: 1.0
In-Reply-To: <m2pq9jo7jf.fsf@guru.guru-group.fi>
References: <20120531214259.GA18272@desktop>
	<m2pq9jo7jf.fsf@guru.guru-group.fi>
Date: Fri, 1 Jun 2012 10:54:25 +0200
Message-ID:
 <CAMP44s0vvEDLd2DceFraNpqyMrX2A+=zkV6W=ABatZs52FNo5Q@mail.gmail.com>
Subject: Re: Can't compile notmuch-delivery
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: notmuch@notmuchmail.org
Precedence: list

On Fri, Jun 1, 2012 at 8:44 AM, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Fri, Jun 01 2012, Jostein Gogstad <jostein.gogstad@gmail.com> wrote:

>> I'm trying to compile notmuch-deliver, but after I get this error:
>>
>> =C2=A0 CC =C2=A0 =C2=A0 main.o
>> =C2=A0 main.c: In function =E2=80=98main=E2=80=99:
>> =C2=A0 main.c:432: error: too few arguments to function =E2=80=98notmuch=
_database_open=E2=80=99
>> =C2=A0 make[2]: *** [main.o] Error 1
>>
>> Any ideas? Tried with the version that ships with 0.13, and the version
>> in HEAD (they seem similar though).
>
> Yes, commit 5fddc07d (*) changes notmuch_database_open() interface. Austi=
n
> or Ali may fix that some day...
>
> .. or Someone Else(TM)... patches welcome :D

I'd say the one who breaks the API does the necessary changes in all
notmuch code, otherwise what's the point of having the code in the
same repo? This is how the Linux kernel does it.

I would be in favor of reverting these changes, and possibly put them
in a separate branch, until they are ready (as in all notmuch code
compiles).

Cheers.

--=20
Felipe Contreras