Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C7C8F4196F2 for ; Mon, 12 Apr 2010 21:20:05 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.001 X-Spam-Level: X-Spam-Status: No, score=-0.001 tagged_above=-999 required=5 tests=[BAYES_40=-0.001] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vudoOMNO7843 for ; Mon, 12 Apr 2010 21:20:05 -0700 (PDT) Received: from office.neopsis.com (office.neopsis.com [78.46.209.98]) by olra.theworths.org (Postfix) with ESMTP id E9A8B431FC1 for ; Mon, 12 Apr 2010 21:20:04 -0700 (PDT) Received: from calvin.caurea.org ([62.65.141.13]) (authenticated user tom@dbservice.com) by office.neopsis.com (using TLSv1/SSLv3 with cipher AES256-SHA (256 bits)); Tue, 13 Apr 2010 06:20:01 +0200 Message-ID: <4BC3F0F1.3000509@dbservice.com> Date: Tue, 13 Apr 2010 06:20:01 +0200 From: Tomas Carnecky User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: Dirk Hohndel Subject: Re: [PATCH] Add simplistic reimplementation of strcasestr to compat library References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2010 04:20:05 -0000 On 4/13/10 6:10 AM, Dirk Hohndel wrote: > > While all systems that I have access to support strcasestr, it is > in fact not part of POSIX. So here's a fallback reimplementation > based on POSIX functions. Your patch is missing the part where it adds -DHAVE_STRCASESTR=.. to CONFIGURE_C{XX,}FLAGS. And I still have to figure out the licencing of my patch (need to wait for the original author to respond). So maybe your patch, with the missing parts added, is better. tom