Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 5BBFD431FAF
	for <notmuch@notmuchmail.org>; Thu,  2 Feb 2012 07:25:17 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id jPHip1a7hKFs for <notmuch@notmuchmail.org>;
	Thu,  2 Feb 2012 07:25:16 -0800 (PST)
Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
	by olra.theworths.org (Postfix) with ESMTP id C37E9431FAE
	for <notmuch@notmuchmail.org>; Thu,  2 Feb 2012 07:25:16 -0800 (PST)
Received: by guru.guru-group.fi (Postfix, from userid 501)
	id 9D5D768055; Thu,  2 Feb 2012 17:25:19 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Edmondson <dme@dme.org>,
	Jameson Graef Rollins <jrollins@finestructure.net>,
	Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible
In-Reply-To: <cuny5sl5mp7.fsf@hotblack-desiato.hh.sledj.net>
References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>
	<87r4yfszx9.fsf@servo.finestructure.net>
	<87pqdync64.fsf@gmail.com> <m262fqc0wv.fsf@guru.guru-group.fi>
	<87k446n8ji.fsf@gmail.com> <87ehuetqjz.fsf@servo.finestructure.net>
	<cuny5sl5mp7.fsf@hotblack-desiato.hh.sledj.net>
User-Agent: Notmuch/0.11+146~geb6dc33 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Thu, 02 Feb 2012 17:25:19 +0200
Message-ID: <m2d39xb6lc.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Feb 2012 15:25:17 -0000

On Thu, 02 Feb 2012 14:33:56 +0000, David Edmondson <dme@dme.org> wrote:
> On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> > If this is really a problem, I vote for 1.  In general, I am not in
> > favor of making the test suite more complicated than it needs to be.
> 
> After listening to the debate, I agree. The documentation should state
> that the order is 'expected actual' (or the other way around) and
> offenders should be shot on sight^W^W^Wfixed.

I've started to agree with Dmitry.

Why do something that computer can do -- to guide test writers to
give args in consistent order and provide suitable filenames.

Secondly as the output files are provided for human consumption
if there is consistent naming in expected output files helps 
developers getting parts of the big picture easier and finding 
right filenames easier.

... and the reviewers doesn't need to keep their plasma guns
handly.

Tomi