From: Thomas Jost <schnouki@schnouki.net>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'
In-Reply-To: <1324491506-1134-2-git-send-email-dmitry.kurochkin@gmail.com>
References: <1324491506-1134-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1324491506-1134-2-git-send-email-dmitry.kurochkin@gmail.com>
User-Agent: Notmuch/0.10.2+131~gde16f21 (http://notmuchmail.org)
	Emacs/24.0.92.1 (x86_64-unknown-linux-gnu)
Date: Wed, 21 Dec 2011 22:49:13 +0100
Message-ID: <87ipl9k33a.fsf@schnouki.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed, 21 Dec 2011 22:18:26 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
l.com> wrote:
> Test that `notmuch-hello-refresh-hook' is called once when
> `notmuch-hello' is called and twice when calling
> `notmuch-hello-update' after that.
>=20
> The tests are very similar to tests for `notmuch-hello-mode-hook'.

Quite nice, better than what I sent earlier [1] :)

However I'm not sure that notmuch-hello.el is the right place for this
kind of stuff; notmuch-lib.el may be better (so that it can also be used
in other hooks.

Regards,
Thomas

[1] id:"1324473189-8622-1-git-send-email-schnouki@schnouki.net"


> ---
>  test/emacs       |   19 +++++++++++++++++++
>  test/test-lib.el |    1 +
>  2 files changed, 20 insertions(+), 0 deletions(-)
>=20
> diff --git a/test/emacs b/test/emacs
> index dffad0f..ca82445 100755
> --- a/test/emacs
> +++ b/test/emacs
> @@ -495,4 +495,23 @@ counter=3D$(test_emacs \
>  )
>  test_expect_equal "$counter" 1
>=20=20
> +test_begin_subtest "notmuch-hello-refresh hook is called"
> +counter=3D$(test_emacs \
> +    '(let ((notmuch-hello-refresh-hook-counter 0))
> +       (kill-buffer "*notmuch-hello*")
> +       (notmuch-hello)
> +       notmuch-hello-refresh-hook-counter)'
> +)
> +test_expect_equal "$counter" 1
> +
> +test_begin_subtest "notmuch-hello-refresh hook is called on updates"
> +counter=3D$(test_emacs \
> +    '(let ((notmuch-hello-refresh-hook-counter 0))
> +       (kill-buffer "*notmuch-hello*")
> +       (notmuch-hello)
> +       (notmuch-hello-update)
> +       notmuch-hello-refresh-hook-counter)'
> +)
> +test_expect_equal "$counter" 2
> +
>  test_done
> diff --git a/test/test-lib.el b/test/test-lib.el
> index 83b8a65..3b817c3 100644
> --- a/test/test-lib.el
> +++ b/test/test-lib.el
> @@ -75,3 +75,4 @@ nothing."
>    (add-hook hook (apply-partially 'hook-counter hook)))
>=20=20
>  (add-hook-counter 'notmuch-hello-mode-hook)
> +(add-hook-counter 'notmuch-hello-refresh-hook)
> --=20
> 1.7.7.3
>=20
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

=2D-=20
Thomas/Schnouki

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEcBAEBAgAGBQJO8lRZAAoJEMPdciX+bh5IhBIH/0940E8MabvAHXfDGp0zRDa0
TZAJYzGcnfFiwE0a3q7ryLHtavqVsqbCh4jQsdfDWY69gw0DPfiSV8tBK6lUT9fj
D2pO5eAIcGBleZJmmen5eX2zXEn1gQFYzgT9oGWt0SYLTzNQ36YVwVYa3AZxsMYJ
DNqV+q1OQttrJ2VXI5bnSuW8HE4k9xZRvvJqSq0FOY8A98ukk8M6tcpsQYLQJp+1
SbuvSy/h/anjNHqPj+iDc0iZ78Xyq6FlXzMea+2rC6dpWzuZfIhVdpx9yyFZHvsm
tsBbzrh0XTonZQJ+LU2tTPc//wEZpFwtRMhszXgl/T6O8EMe99IWsIlVFHdBYUg=
=US3y
-----END PGP SIGNATURE-----
--=-=-=--