Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 04016431FD0 for ; Fri, 9 Sep 2011 11:58:24 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VnR7w9D1yAxD for ; Fri, 9 Sep 2011 11:58:23 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 27696431FB6 for ; Fri, 9 Sep 2011 11:58:23 -0700 (PDT) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id 6A4613281CC; Fri, 9 Sep 2011 11:58:22 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (gwave-120.ligo.caltech.edu [131.215.114.120]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id 71183328143; Fri, 9 Sep 2011 11:58:17 -0700 (PDT) Received: by finestructure.net (Postfix, from userid 1000) id B97A11A0; Fri, 9 Sep 2011 11:58:16 -0700 (PDT) From: Jameson Graef Rollins To: Thomas Schwinge , Austin Clements Subject: Re: [PATCH] notmuch restore --accumulate In-Reply-To: <87fwk53a1i.fsf@kepler.schwinge.homeip.net> References: <1315249637-20179-1-git-send-email-thomas@schwinge.name> <87liu2kcq6.fsf@servo.factory.finestructure.net> <20110909090633.GA3178@localdomain> <87fwk63v86.fsf@kepler.schwinge.homeip.net> <87fwk53a1i.fsf@kepler.schwinge.homeip.net> User-Agent: Notmuch/0.7-41-g7dce23e (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 09 Sep 2011 11:58:14 -0700 Message-ID: <87boutee61.fsf@servo.factory.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2011 18:58:24 -0000 --=-=-= On Fri, 09 Sep 2011 19:22:49 +0200, Thomas Schwinge wrote: > Ah, that's indeed a good approach for bug fixes (and it also preserves > git bisect compatibility), but still: why separate patches for new > functionality? (I'm not trying to be a pain here, but would like to > understand your rationale behind this.) I tend to think of the test as an actual spec of the behavior I'm trying to implement. By defining before hand exactly what I expect to happen I can confirm that my patch achieves what I want it to. As an example, you might look at my patch that adds better rfc822 part handling [0]. I tried to fully flesh out what I wanted to happen in the test first, and then modified the code to achieve that result. jamie. [0] id:"1307320169-29905-4-git-send-email-jrollins@finestructure.net" --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJOamHGAAoJEO00zqvie6q8T40P+wbMuGVZx1lcxvrp7u1bTnNf XKSBVYOe9PJgU5z/cBjLAsy9vcnYKXgT8wTrZ4RRqYsOsKrvo1ECBdtzKppp5nDr mEgsV6V8ZvWVn8rPyOFUBLBXyyVmfnndr4g+xUT8OwouEIya0ntaixOI/RHkIO+2 +9yAcvKMBGEZozupIqXKlvoYIWuyEhJlSKoS4Zzc4k1k+ihk3lFiDALWX2UVVtc7 FXdTuqLAq/J53+BqCUbhPgsGoPSrZjcuzQDZ/1ZcKdQjfDcbMH+4iIBRlqQ4KOkL m6WsS2H4cZrCMu0DSQEPfvTMKsbYnTQmNj+r8D46sZTjYtOYcora/U5wErr/PQzl D4UExNkJcu1Oy/VJjVq9sG4j9LGkznPRl0bu+11CUzicot5+Z1lXZbNT48UyON7E 1SSod/80HNS1qzrO49FpPnNug8nIROwQNjBAoLDzZNd8MeD8+w32t1vchXLwyM33 fEOnvEw7FBKyJp9QgGaiiBx4u18y74VT4GBG1tPVWEPJJpJDb0cK24cwD1vXg8nC w4yJhxUZZTWkxYZwO4B8pxebMGpSZeMHc/eflaWPnpU38dYsDsJdNBJLIypYyUgR pucV8uTedBw+7+SkXfS5DwuqBjZZQbeRaTypptubLbCbz7DdQ3kUyMBjlwhBI3ds XDxqRMwkiBkBvR4O0x+m =8ss5 -----END PGP SIGNATURE----- --=-=-=--