From: Carl Worth <cworth@cworth.org>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
 notmuch@notmuchmail.org
In-Reply-To: <1259452657-27608-1-git-send-email-jrollins@finestructure.net>
References: <1259452657-27608-1-git-send-email-jrollins@finestructure.net>
Date: Fri, 04 Dec 2009 16:12:47 -0800
Message-ID: <87ocmee0sg.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Subject: Re: [notmuch] [PATCH 1/3] fix configure script to handle --prefix=
 and properly create Makefile.config
Precedence: list

--=-=-=

On Sat, 28 Nov 2009 18:57:35 -0500, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> This also removes the Makefile.config from the repository, since it
> shouldn't be kept in the repository and should be created by the
> configure script.

Hi Jamie,

Handling --prefix will be a nice addition to our configure script. So,
thanks!

Your commit message has that flag word of "also" in it, and as it turns
out, the removal of Makefile.config from the repository has actually
happened already. But that was easy enough to fix.

> +# option parsing
> +for option; do
> +    if [ "${option%=*}" = '--prefix' ] ; then
> +	PREFIX="${option#*=}"
> +    fi
> +done

I've gone ahead and committed that now. Then I noticed that we should
really use ${option%%=*} to support the case of an option value
containing an '=' character. So I fixed that.

Then, since I was in the area, I added support to configure for
capturing CFLAGS from the environment, I fixed this (and also "make
CFLAGS=") to also influence C++ compilation (still can be separately
overridden with CXXFLAGS), and I fixed our quiet-compilation mode to
actually print the (user-specified) CFLAGS.

Finally, I documented things by adding a "configure --help" to document
CC, CFLAGS, and --prefix; and by making "make" tell the user about
"./configure" and "./configure --help" when make runs configure
implicitly.

Our configuration system certainly isn't as full-featured yet as a
standard autoconf-based configure script, but I'm quite happy with how
clean it is for both users and developers.

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLGaV/6JDdNq8qSWgRAoTsAKCa8LqALafG9tGjAGTP4HQat8YHEwCffMjd
qwhQlBNHuaC+vk1iNwhe/jM=
=gFfw
-----END PGP SIGNATURE-----
--=-=-=--