From: Carl Worth <cworth@cworth.org>
To: Dirk Hohndel <hohndel@infradead.org>, notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH 2/2] guess From address from Received headers
In-Reply-To: <m3sk78xt3e.fsf@x200.gr8dns.org>
References: <m3sk78xt3e.fsf@x200.gr8dns.org>
Date: Tue, 06 Apr 2010 18:55:34 -0700
Message-ID: <87aatg6n6x.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Tue, 06 Apr 2010 12:45:57 -0700, Dirk Hohndel <hohndel@infradead.org> wrote:
>  When replying to a message notmuch tries to pick the correct From
>  address by looking which one of a user's configured email addresses
>  were included in To or Cc headers of the email that is being replied to.
>  If none of the users email addresses are in the To or Cc headers we now
>  try to guess from the first (chronologically, last) Received header
>  which domain this email was received in and therefore which of the
>  email addresses to use in a reply
>  If that fails we still use the primary email as From email

Thanks, Dirk.

This looks like an awfully useful and clever piece of
functionality. I've applied this patch, (with some tiny style
cleanups[*] afterwards), along with the previous patch that this depends
on.

I'd like to have a test case in the test suite for this as well, but I'm
not going to make the patch block on that (instead I just added that to
TODO).

-Carl

[*] I really need to add a CODING_STYLE document to advertise my
preferred style issues. And before you ask, yes, there *is* a patch for
that.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLu+YW6JDdNq8qSWgRAg12AJkBy9zLEwu8gvzgy6Ky+ArP9xKxlgCfQR/t
bTqJviAk9eGeuX7qU6NRLYE=
=LKCa
-----END PGP SIGNATURE-----
--=-=-=--