Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B5DBC431FBC for ; Wed, 18 Nov 2009 21:56:52 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xKkSzZYPnTVX for ; Wed, 18 Nov 2009 21:56:50 -0800 (PST) Received: from e23smtp09.au.ibm.com (e23smtp09.au.ibm.com [202.81.31.142]) by olra.theworths.org (Postfix) with ESMTP id 41F95431FAE for ; Wed, 18 Nov 2009 21:56:49 -0800 (PST) Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [202.81.31.246]) by e23smtp09.au.ibm.com (8.14.3/8.13.1) with ESMTP id nAJ5umTZ017237 for ; Thu, 19 Nov 2009 16:56:48 +1100 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id nAJ5rTmR1294450 for ; Thu, 19 Nov 2009 16:53:29 +1100 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id nAJ5umJu017976 for ; Thu, 19 Nov 2009 16:56:48 +1100 Received: from skywalker.linux.vnet.ibm.com (N20wks267599wss.in.ibm.com [9.124.31.111]) by d23av01.au.ibm.com (8.14.3/8.13.1/NCO v10.0 AVin) with ESMTP id nAJ5uihJ017921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 19 Nov 2009 16:56:47 +1100 Date: Thu, 19 Nov 2009 11:26:43 +0530 From: "Aneesh Kumar K.V" To: Keith Packard Message-ID: <20091119055643.GA2778@skywalker.linux.vnet.ibm.com> References: <1258606537-12566-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Cc: notmuch@notmuchmail.org Subject: Re: [notmuch] [PATCH] notmuch: Add search mode hook X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2009 05:56:52 -0000 On Wed, Nov 18, 2009 at 09:21:11PM -0800, Keith Packard wrote: > On Thu, 19 Nov 2009 10:25:37 +0530, "Aneesh Kumar K.V" wrote: > > > This patch add notmuch-search-mode-hook and rename > > notmuch-show-hook to notmuch-show-mode-hook. This > > also runs notmuch-show-mode-hook when we enable > > notmuch-show-mode > > I'm not sure we want to run the hooks that early; I can easily imagine > hooks that want to be run after the message has been loaded. Ok i will move them and send another patch -aneesh