From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag
In-Reply-To: <8739azqt2j.fsf@qmul.ac.uk>
References: <20120124011609.GX16740@mit.edu>
	<1327367923-18228-2-git-send-email-markwalters1009@gmail.com>
	<20120124024521.GY16740@mit.edu> <874nvg6qxn.fsf@qmul.ac.uk>
	<20120128183340.GD17991@mit.edu> <8739azqt2j.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.11+136~g22c824b (http://notmuchmail.org) Emacs/23.2.1
	(i486-pc-linux-gnu)
Date: Sun, 29 Jan 2012 10:37:01 +0000
Message-ID: <87zkd6pzg2.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list


> The cli stuff needs thought (about what it should do rather than
> how to do it).

Ok I have thought about the cli interface. My thoughts are as follows:

count/search/show should all have a --do-not-exclude option.

notmuch count:

        messages: just output count of matching not-excluded

        threads: count threads matching in a non-excluded message

notmuch search: 

        default/summary should output line as in the current patch with
        number matching being number non-excluded matching (so some will
        be zero)

        messages/files/tags should be matching not-excluded

        threads:  show thread ids of messages matching in a non-excluded message

notmuch show: 

        raw and part both deal with a single message so should output it
        regardless of exclude flags.

        text/json can give out the results including the exclude flag

        mbox only include matching not-excluded

The rationale is that all formats which can return an exclude flag do;
those that cannot omit the excluded results since the caller can just
call without setting the excludes if they want the full results.

Does that seem reasonable?

Best wishes

Mark