From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>,
	Jameson Graef Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible
In-Reply-To: <m28vknaq5l.fsf@guru.guru-group.fi>
References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>
	<87r4yfszx9.fsf@servo.finestructure.net>
	<m28vknaq5l.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 01 Feb 2012 13:23:19 +0400
Message-ID: <87mx92nbzs.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Wed, 01 Feb 2012 10:55:50 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Wed, 01 Feb 2012 00:47:30 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> > On Wed,  1 Feb 2012 11:19:54 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > > The down side of this approach is that diff argument order depends on
> > > test_expect_equal_file() argument order.  So sometimes we get diff
> > > from expected to actual results, and sometimes the other way around.
> > > But the files are always named correctly.
> > 
> > Actually, I think this last point is the most important thing to retain.
> > Consistency in the diffs makes reading test results much more efficient.
> > The order I don't much care about.  But seeing as we have been
> > consistent with a particular order for a while, it seems like more
> > effort than it's worth to change it.
> 
> how about enforcing it in the test suite ?
> 
> case $file2 in 
> 	*.expected|*.EXPECTED) ;; 
>         *) echo "$file2" does not end with 'expected' >&2; exit 1
> esac
> 

It would break some existing tests.  But I like it.

Regards,
  Dmitry

> > 
> > jamie.
> 
> Tomi