From: David Bremner <david@tethera.net>
Newsgroups: 
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] new: Don't scan unchanged directories with no
	sub-directories
In-Reply-To: <878uxgvqh2.fsf@zancas.localnet>
References: <20131024210837.GH20337@mit.edu>
	<1382650739-12438-1-git-send-email-amdragon@mit.edu>
	<878uxgvqh2.fsf@zancas.localnet>
User-Agent: Notmuch/0.16+97~g6878b0b (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 26 Oct 2013 08:52:55 -0300
Message-ID: <87vc0ktfjc.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list

--=-=-=
Content-Type: text/plain

David Bremner <david@tethera.net> writes:

> Austin Clements <amdragon@MIT.EDU> writes:
>
>> This can substantially reduce the cost of notmuch new in some
>> situations, such as when the file system cache is cold or when the
>> Maildir is on NFS.
>
> On my desktop at home (a core i7 950) with spinning rust disks (and lvm
> on luks) this patch yields about a 7% slowdown in the intial new perf
> test
>
> from
>
> 			Wall(s)	Usr(s)	Sys(s)	Res(K)	In/Out(512B)
>   Initial notmuch new   579.60	348.86	14.26	217188	5330266/3501272
>
> to
>
> 			Wall(s)	Usr(s)	Sys(s)	Res(K)	In/Out(512B)
>   Initial notmuch new   620.51	368.62	15.48	217156	5330354/3416456
>
> On an SSD I don't detect a significant different (<0.5% speedup)

Seems like a false alarm. Averaging over 10 repetitions, the patched
version is about 1% faster. Unfortunately it points out that our
performance test suite should really do more than one repetition for
each test.


--=-=-=
Content-Type: text/x-sh
Content-Disposition: inline; filename=crunch.sh

#!/bin/bash

test_description='notmuch new'

. ./perf-test-lib.sh

time_start
for i in $(seq 1 10); do
    rm -rf ${MAIL_DIR}/.notmuch
    sudo /home/bremner/config/scripts/drop-caches
    time_run "notmuch new #$i" 'notmuch new'
done

time_done

--=-=-=
Content-Type: application/octet-stream
Content-Disposition: attachment; filename=drop-caches
Content-Transfer-Encoding: base64

c3luYwpzeW5jCmVjaG8gMSA+IC9wcm9jL3N5cy92bS9kcm9wX2NhY2hlcwplY2hvIDIgPiAvcHJv
Yy9zeXMvdm0vZHJvcF9jYWNoZXMKZWNobyAzID4gL3Byb2Mvc3lzL3ZtL2Ryb3BfY2FjaGVzCg==
--=-=-=--