Return-Path: <markwalters1009@gmail.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 84BB5431FD2
	for <notmuch@notmuchmail.org>; Sat, 12 Apr 2014 05:46:44 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0.201
X-Spam-Level: 
X-Spam-Status: No, score=0.201 tagged_above=-999 required=5
	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
	FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,
	RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Ji9rsrPWHf+u for <notmuch@notmuchmail.org>;
	Sat, 12 Apr 2014 05:46:40 -0700 (PDT)
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
	[209.85.212.180]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 7B922431FC0
	for <notmuch@notmuchmail.org>; Sat, 12 Apr 2014 05:46:35 -0700 (PDT)
Received: by mail-wi0-f180.google.com with SMTP id q5so2211020wiv.7
	for <notmuch@notmuchmail.org>; Sat, 12 Apr 2014 05:46:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=from:to:cc:subject:date:message-id:in-reply-to:references;
	bh=0N7zkKrdkdEsT6T7/lmDXo9VND3fS33OfTyejR9MIGQ=;
	b=M7DnLVrkk686AaHWc0FteVQaufztdjBKcByu2Epp3DuRMu9K+3xN+02vLAvX3G0Im/
	sSLntX+fQJq+y5oqr2UWr9vgy3EUKMYu5hmmYBCveJf1inEa4vN9n7xHhsbiNDxEDRnf
	+k05ffP5bHsEdATXzDf+3vKegPqdmdg84wT5bSUdYRMRPtoJNK4Eiub7lgh2LfICDTY0
	tB37vdNc+Xsws8Pi3skj8XR0N2oDLiwsyUSoPSEMBxOud6QM/nHU66g4R12tRgyLieZ3
	Egpzrefp+QZAekSAXyELLLJHNZ107yqrW+iYdATfEQpL8So1o892BjU2p3NamVp5NBPJ
	TPSQ==
X-Received: by 10.194.24.74 with SMTP id s10mr1654446wjf.43.1397306794358;
	Sat, 12 Apr 2014 05:46:34 -0700 (PDT)
Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])
	by mx.google.com with ESMTPSA id q2sm10449608wix.5.2014.04.12.05.46.33
	for <multiple recipients>
	(version=TLSv1.2 cipher=RC4-SHA bits=128/128);
	Sat, 12 Apr 2014 05:46:33 -0700 (PDT)
From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH v2 2/2] NEWS: document possible breakage from saved-search
	format change
Date: Sat, 12 Apr 2014 13:46:27 +0100
Message-Id: <1397306787-12207-3-git-send-email-markwalters1009@gmail.com>
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1397306787-12207-1-git-send-email-markwalters1009@gmail.com>
References: <1397306787-12207-1-git-send-email-markwalters1009@gmail.com>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Apr 2014 12:46:44 -0000

If the user has unsorted or alphabetically sorted saved-searches these
should continue to work. If they have some custom lisp sort function
then it will need updating to work with the new saved-sort
format. Document this, and how the updating should be done.

Also roll in fixes for the markdown in the first part of the NEWS
suggested by Tomi: change `just work' to *just work* and removed
periods from the end of subtitle lines.
---
 NEWS |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/NEWS b/NEWS
index 8aa4182..f1d5499 100644
--- a/NEWS
+++ b/NEWS
@@ -15,7 +15,7 @@ Command-Line Interface
 Emacs Interface
 ---------------
 
-Changed format for saved searches.
+Changed format for saved searches
 
   The format for `notmuch-saved-searches` has changed, but old style
   saved searches are still supported. The new style means that a saved
@@ -24,7 +24,7 @@ Changed format for saved searches.
   shows.
 
   The variable is fully customizable and any configuration done
-  through customize should `just work', with the additional options
+  through customize should *just work*, with the additional options
   mentioned above. For manual customization see the documentation for
   `notmuch-saved-searches`.
 
@@ -32,7 +32,13 @@ Changed format for saved searches.
   previous versions of notmuch-emacs (even search will not work); to
   fix remove the customization for notmuch-saved-searches.
 
-Bug fix for saved searches with newlines in them.
+  If you have a custom saved search sort function (not unsorted or
+  alphabetical) then the sort function will need to be
+  modified. Replacing (car saved-search) by (notmuch-saved-search-get
+  saved-search :name) and (cdr saved-search) by
+  (notmuch-saved-search-get saved-search :query) should be sufficient.
+
+Bug fix for saved searches with newlines in them
 
   Split lines confuse `notmuch count --batch`, so we remove embedded
   newlines before calling notmuch count.
-- 
1.7.10.4