Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 59729429E31 for ; Thu, 12 Jan 2012 09:21:54 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gvvyZ6GP4BXJ for ; Thu, 12 Jan 2012 09:21:54 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id B7FD5429E29 for ; Thu, 12 Jan 2012 09:21:53 -0800 (PST) Received: by wgbds11 with SMTP id ds11so1959821wgb.2 for ; Thu, 12 Jan 2012 09:21:52 -0800 (PST) Received: by 10.180.14.161 with SMTP id q1mr2066499wic.1.1326388912568; Thu, 12 Jan 2012 09:21:52 -0800 (PST) Received: from localhost ([109.131.126.209]) by mx.google.com with ESMTPS id o1sm5552156wbh.9.2012.01.12.09.21.51 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 Jan 2012 09:21:51 -0800 (PST) From: Pieter Praet To: Jameson Graef Rollins , Notmuch Mail Subject: Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links In-Reply-To: <1324616352-15337-1-git-send-email-jrollins@finestructure.net> References: <1324616352-15337-1-git-send-email-jrollins@finestructure.net> User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Thu, 12 Jan 2012 18:20:12 +0100 Message-ID: <874nw0ltwz.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 17:21:54 -0000 On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins wrote: > Since message-ids necessarily match just a single message, there's no > reason to do a search for the id before viewing the actual message; > the search just becomes an extra screen to click through. Clicking on > an id: links now just jumps straight to the message itself. > --- > This just fixes the subject of the patch, which had a typo. Sorry. > > emacs/notmuch-show.el | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 98db8f2..623d521 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -803,7 +803,7 @@ a corresponding notmuch search." > (remove-overlays (match-beginning 0) (match-end 0) 'goto-address t) > (make-text-button (match-beginning 0) (match-end 0) > 'action `(lambda (arg) > - (notmuch-search ,(match-string-no-properties 0))) > + (notmuch-show ,(match-string-no-properties 0))) > 'follow-link t > 'help-echo "Mouse-1, RET: search for this message" > 'face goto-address-mail-face)))) > -- > 1.7.7.3 Anti-RSI FTW! However... If no message with that id: exists, `notmuch-show' will drop us to a blank screen. See id:"87lisjzrsc.fsf@kepler.schwinge.homeip.net" for some mock 'id:' links which demonstrate this nicely. Patches follow. Peace -- Pieter