Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8994B429E20 for ; Sat, 7 May 2011 02:14:13 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JvvCOYMR-Eqt for ; Sat, 7 May 2011 02:14:13 -0700 (PDT) Received: from mail-wy0-f181.google.com (mail-wy0-f181.google.com [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id C9A21431FB5 for ; Sat, 7 May 2011 02:14:12 -0700 (PDT) Received: by wyi11 with SMTP id 11so3181401wyi.26 for ; Sat, 07 May 2011 02:14:11 -0700 (PDT) Received: by 10.216.203.195 with SMTP id f45mr477025weo.89.1304759651155; Sat, 07 May 2011 02:14:11 -0700 (PDT) Received: from localhost (197.83-240-81.adsl-dyn.isp.belgacom.be [81.240.83.197]) by mx.google.com with ESMTPS id ed10sm2477037wbb.66.2011.05.07.02.14.09 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 07 May 2011 02:14:10 -0700 (PDT) From: Pieter Praet To: Jameson Graef Rollins , Austin Clements , Florian Friesdorf Subject: Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it In-Reply-To: <87liyjgvyw.fsf@servo.factory.finestructure.net> References: <1304723846-29134-1-git-send-email-flo@chaoflow.net> <1304723846-29134-2-git-send-email-flo@chaoflow.net> <87liyjgvyw.fsf@servo.factory.finestructure.net> User-Agent: Notmuch/0.5-98-g63c37b1 (http://notmuchmail.org) Emacs/23.1.50.1 (x86_64-pc-linux-gnu) Date: Sat, 07 May 2011 11:14:08 +0200 Message-ID: <87pqnukh3z.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org, a.amann@ucc.ie X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 May 2011 09:14:13 -0000 On Fri, 06 May 2011 18:06:47 -0700, Jameson Graef Rollins wrote: > On Fri, 6 May 2011 19:55:26 -0400, Austin Clements wrote: > > Perhaps text summary output should *always* do this. The text summary > > format is meant half for user consumption and half for emacs > > consumption and allowing newlines that don't indicate the end of a > > summary line seems bad for *both* use cases. > > Hi, Florian. I think I agree with Austin here that the text output > should probably just always be sanitized. Can you try sending in a > patch that just automatically sanitizes the text output? Indeed, Andreas and I agreed [1] as well that sanitization should be default for search, yet optional for show. > Also, I believe that this patch is not entirely compatible with the > current head of the release-candidate/0.6 branch. I pushed a patch to > that branch to fix a search output formatting bug, and in so doing I > added a field to the search_format struct. > > If you could make those changes and post a new patch that would be > great. Thanks. > > jamie. Non-text part: application/pgp-signature > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch Peace -- Pieter [1] id:"87pqokx7op.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me"