From: Tomi Ollila <tomi.ollila@iki.fi>
To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX()
In-Reply-To: <1369052664-17869-3-git-send-email-felipe.contreras@gmail.com>
References: <1369052664-17869-1-git-send-email-felipe.contreras@gmail.com>
	<1369052664-17869-3-git-send-email-felipe.contreras@gmail.com>
User-Agent: Notmuch/0.15.2+99~g7e455bc (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Tue, 21 May 2013 17:17:37 +0300
Message-ID: <m2vc6c4dtq.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Cc: Ali Polatel <alip@exherbo.org>
Precedence: list

On Mon, May 20 2013, Felipe Contreras <felipe.contreras@gmail.com> wrote:

> It has never existed in Ruby (maybe JRuby). Fortunately the symbols are
> loaded lazily, so nobody would notice unless they try
> 'query::count_messages'.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>

This patch could be pushed on it's own, but someone (like Ali) could
comment on the change as searches on both UINT2FIX() & UINT2NUM()
provides (IMH) insatisfactory results...

Tomi

> ---
>  bindings/ruby/query.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bindings/ruby/query.c b/bindings/ruby/query.c
> index e5ba1b7..1658ede 100644
> --- a/bindings/ruby/query.c
> +++ b/bindings/ruby/query.c
> @@ -180,5 +180,5 @@ notmuch_rb_query_count_messages (VALUE self)
>       * (function may return 0 after printing a message)
>       * Thus there is nothing we can do here...
>       */
> -    return UINT2FIX(notmuch_query_count_messages(query));
> +    return UINT2NUM(notmuch_query_count_messages(query));
>  }
> -- 
> 1.8.3.rc3.286.g3d43083
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch